Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

no issue but: collapsible-content gets background now #2467

Closed
MauriceG opened this Issue Sep 17, 2011 · 10 comments

Comments

Projects
None yet
4 participants
Contributor

MauriceG commented Sep 17, 2011

As of latest from 14.09.2011 collapsible-contents gets the ui-btn-up-c class by default and the background is not transparent anymore.
The content is themeable but it seems it is not possible to get the transparent background back without a "surgical intervention" ...

It's may a question of taste, but will this now be the standard for collapsible-contents?

before 14.09.2011
http://jquerymobile.com/demos/1.0b3/docs/content/content-collapsible.html

Now:
http://jquerymobile.com/test/docs/content/content-collapsible.html

Contributor

MauriceG commented Sep 17, 2011

Completion: now it may becomes an issue:

Because of the assigned ui-btn-up-c style to all ui-collapsible-content-divs,
all following anchors inherits the text-color of the c-swatch, regardless of which theme its parent have.

demo at: http://jsfiddle.net/MauriceG/zYx7P/

@ghost ghost assigned gseguin Sep 19, 2011

Contributor

toddparker commented Sep 19, 2011

Good catch on the link inheritance, we'll take a look.

The visual connection between the header and body in a collapsible has always been an issue so we've had a ticket to clean this up. Adding a flat color and stroke that matches the swatch of parent is the new design, but I suppose we could think about adding the ability to set the swatch for the content to an empty string "" which would mean no background. @gseguin - what do you think?

Member

gseguin commented Sep 20, 2011

I will try that out on 9/21. See also issue #2460

Contributor

scottjehl commented Sep 21, 2011

I think it may be best to default to the way these looked before this change, but allow people to opt-into the container theme through an option. I like the new look better, but it may not be what people expect to see in an RC. THoughts?

Member

gseguin commented Sep 21, 2011

User would have to add data-content-theme="c" to match the "c" theme of the collapsible header which would set the background and the border? In that case the collapsible header will not have "closing" ui-corner-bottom by default.
Is that right?

Contributor

toddparker commented Sep 21, 2011

That is a good point @gseguin. @scottjehl - we were removing the bottom corners on a collapsible header when open and having the top of the content block un-rounded and the bottom rounded. Looks nice, but if there isn't a border/bg on the content, it will look like the button gets a square bottom when open. How hard is it to put in the conditional logic to say "if there's a theme on the content, remove the bottom border?"

Member

gseguin commented Sep 21, 2011

It shouldn't be too hard to test if option content-theme is set and not toggle that class on the heading/content on expand/collapse.

Contributor

toddparker commented Sep 21, 2011

Cool, so we have a plan. @gseguin - do you have time to get this in today?

Member

gseguin commented Sep 21, 2011

I will try to. But it may not be until late.

Member

gseguin commented Sep 25, 2011

Landed branch collapsible-redesign which takes care of this and issue #1899

@gseguin gseguin closed this Sep 25, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment