New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listviews: first list-item has "glowing" corners on top #2528

Closed
MauriceG opened this Issue Sep 26, 2011 · 4 comments

Comments

Projects
None yet
2 participants
@MauriceG
Contributor

MauriceG commented Sep 26, 2011

The first list-item in listviews has "glowing" corners on top, because the first child-div of the list-item misses the ui-corner-top class.
This is just visible, if the listview has a darker background color like with the a or b swatch and it's invisible with the c or d swatch.

At http://jsfiddle.net/MauriceG/MLBSY/ i've built a demo, where you're able to change the data-content-theme on the fly.
So you can see the glowing corners with different swatches.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Oct 13, 2011

Contributor

More details here: For more detail please visit: http://forum.jquery.com/topic/white-line-above-listview

Contributor

toddparker commented Oct 13, 2011

More details here: For more detail please visit: http://forum.jquery.com/topic/white-line-above-listview

@ghost ghost assigned toddparker Oct 13, 2011

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Oct 20, 2011

Contributor

Thanks! Can you submit as a pull?

Contributor

toddparker commented Oct 20, 2011

Thanks! Can you submit as a pull?

@MauriceG MauriceG closed this Oct 20, 2011

@MauriceG MauriceG reopened this Oct 20, 2011

@MauriceG

This comment has been minimized.

Show comment
Hide comment
@MauriceG

MauriceG Oct 20, 2011

Contributor

Yes! The pull is #2768 and waits for review .
Thanks!

Contributor

MauriceG commented Oct 20, 2011

Yes! The pull is #2768 and waits for review .
Thanks!

toddparker added a commit that referenced this issue Oct 21, 2011

Merge pull request #2768 from MauriceG/patch-10
fix for #2528 listviews: first list-item has "glowing" corners on top. Thanks MauriceG!
@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Oct 27, 2011

Contributor

Looks great MauriceG! Fixed now.

Contributor

toddparker commented Oct 27, 2011

Looks great MauriceG! Fixed now.

timmywil pushed a commit to timmywil/jquery-mobile that referenced this issue Nov 5, 2011

timmywil pushed a commit to timmywil/jquery-mobile that referenced this issue Nov 5, 2011

Merge pull request #2864 from MauriceG/issue_2528
Fixes #2528 - removing listviews glowing corners. Thanks MauriceG!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment