New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new pageremove event #2537

Closed
kurteknikk opened this Issue Sep 26, 2011 · 6 comments

Comments

Projects
None yet
3 participants
@kurteknikk

kurteknikk commented Sep 26, 2011

Hi,

The page events: pagebeforeshow, pageshow, pagebeforehide, pagehide are very usefull in most cases but i think there's a missing event when you compare the pagecreate event with the above...

Because there's no pageremove event, which i think should be triggered when a page is removed from the dom.

The reason being that first of all i think it will be more logical, and secondly my use case is that i need to update the page contents even when its hidden if its still in the dom, so when i remove the page from the dom i want to have some extra logic to clear some stuff.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Sep 26, 2011

Contributor

Can you add this to the feature request wiki and close when done? Thanks!

Contributor

toddparker commented Sep 26, 2011

Can you add this to the feature request wiki and close when done? Thanks!

@ghost ghost assigned jblas Sep 26, 2011

@jblas

This comment has been minimized.

Show comment
Hide comment
@jblas

jblas Sep 26, 2011

Contributor

@kurteknikk

Yeah, makes a lot of sense!

Contributor

jblas commented Sep 26, 2011

@kurteknikk

Yeah, makes a lot of sense!

@kurteknikk

This comment has been minimized.

Show comment
Hide comment
@kurteknikk

kurteknikk Sep 27, 2011

Added to the feature request wiki, thanks :)

kurteknikk commented Sep 27, 2011

Added to the feature request wiki, thanks :)

@kurteknikk kurteknikk closed this Sep 27, 2011

@kurteknikk kurteknikk reopened this Sep 28, 2011

@kurteknikk

This comment has been minimized.

Show comment
Hide comment
@kurteknikk

kurteknikk Sep 28, 2011

Sorry there was a misunderstanding, i closed the issue after i added it to the feature request wiki, i should have closed it when the issue is solved...

kurteknikk commented Sep 28, 2011

Sorry there was a misunderstanding, i closed the issue after i added it to the feature request wiki, i should have closed it when the issue is solved...

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Sep 28, 2011

Contributor

Normally, we'd close issues once added to the feature request wiki page, but it sounds like @jblas is thinking about adding this now.

Contributor

toddparker commented Sep 28, 2011

Normally, we'd close issues once added to the feature request wiki page, but it sounds like @jblas is thinking about adding this now.

@kurteknikk

This comment has been minimized.

Show comment
Hide comment
@kurteknikk

kurteknikk Sep 28, 2011

Ok thanks for the info, also i agree with @jblas that its very important to be added before the first RC is released.

kurteknikk commented Sep 28, 2011

Ok thanks for the info, also i agree with @jblas that its very important to be added before the first RC is released.

@jblas jblas closed this in 34fb7b2 Sep 28, 2011

jblas added a commit that referenced this issue Sep 28, 2011

Added unit test for issue #2537 - Add new pageremove event.
The test makes use of a pageremove callback that conditionally calls preventDefault() on the event so that the test can make sure a developer can prevent a specific page from being removed from the DOM.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment