namespace pollution on 'search' variable (1.0rc1) #2574

Closed
pascalchristian opened this Issue Sep 30, 2011 · 3 comments

Comments

Projects
None yet
3 participants
@pascalchristian

On JQM 1.0rc1, every change page seems to overwrite the 'search' global variable into an empty string (""). This does not occur on beta 3.

To recreate this issue:

  1. Open http://jquerymobile.com/demos/1.0rc1/
  2. Open console and declare two variables:
    var search = "this is search";
    var not_search = "this is not search";
  3. Click on any link
    type search: return ""
    type not_search: return "this is not search"

@ghost ghost assigned jblas Sep 30, 2011

@jblas

This comment has been minimized.

Show comment
Hide comment
@jblas

jblas Sep 30, 2011

Contributor

@pascalchristian

Thanks for catching that ... there was a typo ';' instead of a ',' in one of our var delcarations.

Contributor

jblas commented Sep 30, 2011

@pascalchristian

Thanks for catching that ... there was a typo ';' instead of a ',' in one of our var delcarations.

@jblas jblas closed this in bafc187 Sep 30, 2011

@MauriceG

This comment has been minimized.

Show comment
Hide comment
@MauriceG

MauriceG Sep 30, 2011

Contributor

@jblas

Chapeau !!

Contributor

MauriceG commented Sep 30, 2011

@jblas

Chapeau !!

@pascalchristian

This comment has been minimized.

Show comment
Hide comment
@pascalchristian

pascalchristian Oct 1, 2011

thanks for the quick fix!

thanks for the quick fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment