Refreshing a page with #&ui-state=dialog causes page duplication #2582

Closed
jblas opened this Issue Sep 30, 2011 · 0 comments

Comments

Projects
None yet
1 participant
@jblas
Contributor

jblas commented Sep 30, 2011

After fixing issue #2570:

#2570

And testing against the sample URL:

http://jquerymobile.com/demos/1.0rc1/docs/pages/page-dialogs.html#&ui-state=dialog

I noticed that the page markup for page-dialogs.html was being duplicated in the DOM. This is happening because we aren't detecting that page-dialogs.html is a "first-page" since it has a hash after it. We need to change the first-page checking code in loadPage() so that it uses fileUrl, which is the version of the absUrl, minus any dialog hashKey.

@ghost ghost assigned jblas Sep 30, 2011

@jblas jblas closed this in 98eda9a Sep 30, 2011

jblas added a commit that referenced this issue Sep 30, 2011

Added a test for diretly loading Urls with a hash that contains just …
…the dialogHashKey. This tests to make sure these issues don't happen again:

Issue #2570 - Refreshing a page with #&ui-state=dialog causes syntax error
Issue #2582 - Refreshing a page with #&ui-state=dialog causes page duplication
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment