New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bottom border of single collapsible and last collapsible in set when collapsed #2584

Closed
agcolom opened this Issue Sep 30, 2011 · 9 comments

Comments

Projects
None yet
4 participants
@agcolom
Member

agcolom commented Sep 30, 2011

Hi,

I'll start by saying that I totally love the fact that we can now have the choice of having a background or no background for collapsibles :-)

I am just wondering whether the headers of collapsed single collapsible with no background (and the last collapsible in collapsible set), who get rounded bottom corners when their content is hidden, should loose their rounded corner (and get square ones), so that the consistency of look and behaviour is kept with the headers of collapsibles with background. From a user's point of view, that is the behaviour that I would expect. I find the fact that the bottom rounded corners do not change when the content collapses gives me the impression that the content gets displayed but the 'door' is not opened. The square bottom corners gives the extra cue that something needs to be closed.

(see http://jquerymobile.com/demos/1.0rc1/#/demos/1.0rc1/docs/content/content-collapsible-set.html)

Thanks,

Anne-Gaelle

@agcolom

This comment has been minimized.

Show comment
Hide comment
@agcolom

agcolom Sep 30, 2011

Member

BTW, I've just checked, and that was the behaviour that collapsibles had in version Alpha 4.

Member

agcolom commented Sep 30, 2011

BTW, I've just checked, and that was the behaviour that collapsibles had in version Alpha 4.

@ghost ghost assigned gseguin Sep 30, 2011

@MauriceG

This comment has been minimized.

Show comment
Hide comment
@MauriceG

MauriceG Oct 2, 2011

Contributor

@gseguin
Let's say it in one sentence: :-)
Last item in a open collapsible, with no data-content-theme set, keeps unnessery ui-corner-bottom class.

And this new RC1-feature is in deed a cool one.

Contributor

MauriceG commented Oct 2, 2011

@gseguin
Let's say it in one sentence: :-)
Last item in a open collapsible, with no data-content-theme set, keeps unnessery ui-corner-bottom class.

And this new RC1-feature is in deed a cool one.

@agcolom

This comment has been minimized.

Show comment
Hide comment
@agcolom

agcolom Oct 2, 2011

Member

Well, I couldn't have said this in a more precise and concise way, thanks for that :-) I was used to a different behaviour which could be why it is not the expected one for me now. Up to you guys really whether you want to remove the ui-corner-bottom class for last item in open collapsible with no data-content-theme, or keep it...

Thanks a lot for all your hard work. Everyone I show JQM and what you can do with it is very impressed (and that will include another 300+ students this year).

Member

agcolom commented Oct 2, 2011

Well, I couldn't have said this in a more precise and concise way, thanks for that :-) I was used to a different behaviour which could be why it is not the expected one for me now. Up to you guys really whether you want to remove the ui-corner-bottom class for last item in open collapsible with no data-content-theme, or keep it...

Thanks a lot for all your hard work. Everyone I show JQM and what you can do with it is very impressed (and that will include another 300+ students this year).

@gseguin

This comment has been minimized.

Show comment
Hide comment
@gseguin

gseguin Oct 3, 2011

Member

It's actually on purpose but easily modifiable.

@toddparker, what are your thoughts on making the collapsible/collapsible-set with no content-theme behave the same with regard to their ui-corner-bottom class?

Member

gseguin commented Oct 3, 2011

It's actually on purpose but easily modifiable.

@toddparker, what are your thoughts on making the collapsible/collapsible-set with no content-theme behave the same with regard to their ui-corner-bottom class?

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Oct 3, 2011

Contributor

This is intentional because, to me, it felt odd to have the button get squared off without any other visual connection to the content. It sort of looked like a CSS bug because you have a button that is squared off but you can't really see why.

Like @gseguin said, this is pretty easily modifiable. You could achieve this effect a few ways - either by creating a content theme swatch that matches the color page itself, or with a bit of scripting to remove the bottom corner classes.

This is sort of a debatable thing, but I think I want to close this because we wanted to keep the default visual appearance unchanged from B3 and earlier at this stage. If you want us to re-visit this, add this ticket to the feature request wiki.

Contributor

toddparker commented Oct 3, 2011

This is intentional because, to me, it felt odd to have the button get squared off without any other visual connection to the content. It sort of looked like a CSS bug because you have a button that is squared off but you can't really see why.

Like @gseguin said, this is pretty easily modifiable. You could achieve this effect a few ways - either by creating a content theme swatch that matches the color page itself, or with a bit of scripting to remove the bottom corner classes.

This is sort of a debatable thing, but I think I want to close this because we wanted to keep the default visual appearance unchanged from B3 and earlier at this stage. If you want us to re-visit this, add this ticket to the feature request wiki.

@toddparker toddparker closed this Oct 3, 2011

@agcolom

This comment has been minimized.

Show comment
Hide comment
@agcolom

agcolom Oct 3, 2011

Member

No problem, will try to do that (scripting). It's really one of those things where there is no right or wrong answer. It was nice to be able to discuss this :-)

Member

agcolom commented Oct 3, 2011

No problem, will try to do that (scripting). It's really one of those things where there is no right or wrong answer. It was nice to be able to discuss this :-)

@agcolom

This comment has been minimized.

Show comment
Hide comment
@agcolom

agcolom Oct 3, 2011

Member

@toddparker your comment "I think this is a duplicate of an issue #2584 I just closed?" appears in #2584.

Member

agcolom commented Oct 3, 2011

@toddparker your comment "I think this is a duplicate of an issue #2584 I just closed?" appears in #2584.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Oct 3, 2011

Contributor

Yep, sorry. Confused, wasn't there another duplicate issue somewhere?

Contributor

toddparker commented Oct 3, 2011

Yep, sorry. Confused, wasn't there another duplicate issue somewhere?

@agcolom

This comment has been minimized.

Show comment
Hide comment
@agcolom
Member

agcolom commented Oct 3, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment