Dialog loads new page when ajaxEnabled=false and dialog is external. #2648

Closed
haddnin opened this Issue Oct 7, 2011 · 2 comments

Comments

Projects
None yet
2 participants
@haddnin

haddnin commented Oct 7, 2011

When a dialog page is external and ajaxEnabled is false, the dialog loads in a new page instead of the dialog popup. I saw that there was a fix to "allow embedded/internal pages to be loaded as dialogs when clicking on @data-rel="dialog" links" (issue #2202), but not for external pages. Is there a fix in the works?

Thanx!

@johnbender

This comment has been minimized.

Show comment Hide comment
@johnbender

johnbender Oct 7, 2011

Contributor

@haddnin

I believe we'd have to transmit the intent for the page to be a dialog along with the request to support this and there's a danger there of mucking up a server request (reads: we won't be doing that). If you have access to the document where the page is defined you can give it the requisite data-role to render it as a dialog.

Contributor

johnbender commented Oct 7, 2011

@haddnin

I believe we'd have to transmit the intent for the page to be a dialog along with the request to support this and there's a danger there of mucking up a server request (reads: we won't be doing that). If you have access to the document where the page is defined you can give it the requisite data-role to render it as a dialog.

@johnbender

This comment has been minimized.

Show comment Hide comment
@johnbender

johnbender Oct 7, 2011

Contributor

@haddnin

I was wrong about the data-role=dialog working, and we can certainly address that as a feature addition. Added to the wiki page under navigation:

https://github.com/jquery/jquery-mobile/wiki/Feature-Requests

Contributor

johnbender commented Oct 7, 2011

@haddnin

I was wrong about the data-role=dialog working, and we can certainly address that as a feature addition. Added to the wiki page under navigation:

https://github.com/jquery/jquery-mobile/wiki/Feature-Requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment