New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement request: PNG images could be optimised losslessly #2650

Closed
chrisben opened this Issue Oct 9, 2011 · 11 comments

Comments

Projects
None yet
4 participants
@chrisben

chrisben commented Oct 9, 2011

Using Trimage http://trimage.org/ I get between 6 and 27% compression for the PNG images of jquery mobile. This GUI is actually using optipng or pngcrush optimisations without any quality loss.

In 1.0rc1 it managed to bring down the total size of images from 11.9kB to 10.7kB. It's not that much, but every little helps :)

Could you perhaps add a command line optipng/pngcrush step into your release packaging process?

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Oct 11, 2011

Contributor

This is a good idea. I'll have to look into adding this...

Contributor

toddparker commented Oct 11, 2011

This is a good idea. I'll have to look into adding this...

@eddiemonge

This comment has been minimized.

Show comment
Hide comment
@eddiemonge

eddiemonge Nov 15, 2011

Contributor

I believe this can be closed now. @chrisben Do you agree?

Contributor

eddiemonge commented Nov 15, 2011

I believe this can be closed now. @chrisben Do you agree?

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Nov 15, 2011

Contributor

Of course, I just updated the black sprites so this would need to be re-done.

Contributor

toddparker commented Nov 15, 2011

Of course, I just updated the black sprites so this would need to be re-done.

@chrisben

This comment has been minimized.

Show comment
Hide comment
@chrisben

chrisben Nov 15, 2011

I tested the images found in 1.0rc3 .zip, black images could be even more optimised.

Using Trimage:
icons-18-black : -9.5% 2 kB -> 1kB
icons-36-black : -12% 4 kB -> 3kB

Though loader + white images are now at their minimal size.

Could you check what can be done for the black images before we close this issue?

I tested the images found in 1.0rc3 .zip, black images could be even more optimised.

Using Trimage:
icons-18-black : -9.5% 2 kB -> 1kB
icons-36-black : -12% 4 kB -> 3kB

Though loader + white images are now at their minimal size.

Could you check what can be done for the black images before we close this issue?

@chrisben

This comment has been minimized.

Show comment
Hide comment
@chrisben

chrisben Nov 15, 2011

Yes, in the end the -black.png images should have the same size as the -white.png images.

Yes, in the end the -black.png images should have the same size as the -white.png images.

@chrisben

This comment has been minimized.

Show comment
Hide comment
@chrisben

chrisben Nov 17, 2011

Problem described in my last comments is still there in 1.0 final

Problem described in my last comments is still there in 1.0 final

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Nov 17, 2011

Contributor

I just think we ran out of time on this one. If you submit a pull, we can get this in for 1.0.1

Contributor

toddparker commented Nov 17, 2011

I just think we ran out of time on this one. If you submit a pull, we can get this in for 1.0.1

gseguin added a commit that referenced this issue Nov 17, 2011

Merge pull request #3096 from chrisben/master
Issue #2650: optimisation of png images
@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Nov 21, 2011

Contributor

@gseguin - do you add this to both master and the 1.0.1 branch?

Contributor

toddparker commented Nov 21, 2011

@gseguin - do you add this to both master and the 1.0.1 branch?

@toddparker toddparker closed this Nov 21, 2011

@gseguin

This comment has been minimized.

Show comment
Hide comment
@gseguin

gseguin Nov 21, 2011

Member

@toddparker

This landed only on master, let me know if you want me to cherry-pick it to 1.0-stable as well.

Member

gseguin commented Nov 21, 2011

@toddparker

This landed only on master, let me know if you want me to cherry-pick it to 1.0-stable as well.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Nov 21, 2011

Contributor

Yeah, I think we should.

Contributor

toddparker commented Nov 21, 2011

Yeah, I think we should.

@gseguin

This comment has been minimized.

Show comment
Hide comment
@gseguin

gseguin Nov 21, 2011

Member

It's in: de9d20e

Member

gseguin commented Nov 21, 2011

It's in: de9d20e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment