"degradeInputs" plugin doesn't trigger on "create" events #2654

Closed
redaemn opened this Issue Oct 10, 2011 · 2 comments

Comments

Projects
None yet
3 participants
@redaemn
Contributor

redaemn commented Oct 10, 2011

Here's what I did: inside a page previously created I dinamically inserted the HTML needed to render a slider, then I triggered the "create" event on the "content" div to execute the plugins (as suggested in the documentation). The slider got created but the input[type="range"] didn't degraded to type="number".

I noticed that the "degradeInputs" plugin is bound to the "enhance" event, I think this was renamed to "create" some commit ago. Isn't this a bug?

I tried renaming "enhance" to "create" but it seems that the "degradeInputs" plugin wants to be executed only on data-role="page" elements, some more refactor is needed.

@ghost ghost assigned johnbender and jblas Oct 10, 2011

redaemn added a commit to redaemn/jquery-mobile that referenced this issue Oct 13, 2011

redaemn added a commit to redaemn/jquery-mobile that referenced this issue Oct 13, 2011

@johnbender johnbender closed this Oct 14, 2011

@johnbender johnbender reopened this Oct 14, 2011

@johnbender

This comment has been minimized.

Show comment
Hide comment
@johnbender

johnbender Oct 14, 2011

Contributor

I killed that branch the solution won't work because the reason for triggering create was to get the enhancement as well. Asking everyone to manually degrade the inputs when they want to trigger on page children is silly.

Contributor

johnbender commented Oct 14, 2011

I killed that branch the solution won't work because the reason for triggering create was to get the enhancement as well. Asking everyone to manually degrade the inputs when they want to trigger on page children is silly.

johnbender added a commit that referenced this issue Oct 14, 2011

@redaemn

This comment has been minimized.

Show comment
Hide comment
@redaemn

redaemn Oct 15, 2011

Contributor

@johnbender

Since you merged the branch, shouldn't this issue be closed now?

Contributor

redaemn commented Oct 15, 2011

@johnbender

Since you merged the branch, shouldn't this issue be closed now?

@johnbender johnbender closed this Oct 18, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment