New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward history + dialog #2656

Closed
kenoby opened this Issue Oct 10, 2011 · 6 comments

Comments

Projects
None yet
6 participants
@kenoby

kenoby commented Oct 10, 2011

Steps to reproduce

  1. open http://jquerymobile.com/demos/1.0rc1/docs/pages/page-dialogs.html in a new tab in latest firefox
  2. click "Open dialog"
  3. close dialog via "X" button
  4. click history-forward-button of browser => new hash #&ui-state
  5. click "Open dialog" => hash #&ui-state=dialog&ui-state=dialog
  6. now two clicks on "X" are needed to close dialog

@ghost ghost assigned johnbender Oct 10, 2011

@tommedema

This comment has been minimized.

Show comment
Hide comment
@tommedema

tommedema Oct 11, 2011

Confirmed in Chromium 12.0.742.112 (90304) Ubuntu 10.10.

Confirmed in Chromium 12.0.742.112 (90304) Ubuntu 10.10.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Oct 19, 2011

Contributor

Can you guys disabled pushState and see if that resolves this issue? There are some quirks with the browser implementations that we note here:
http://jquerymobile.com/test/docs/pages/page-navmodel.html

Contributor

toddparker commented Oct 19, 2011

Can you guys disabled pushState and see if that resolves this issue? There are some quirks with the browser implementations that we note here:
http://jquerymobile.com/test/docs/pages/page-navmodel.html

@kenoby

This comment has been minimized.

Show comment
Hide comment
@kenoby

kenoby Oct 19, 2011

I can't test it right now because I use jquerymobile mainly for the gui enhancements. Maybe its because the dialog in this special case is the last entry in history? Normally jquerymobile would skip dialog-history-entries, when you navigate forward or backward e.g. with browserbuttons. But if you navigate forward and the last entry is dialog-hash you can't skip it.

kenoby commented Oct 19, 2011

I can't test it right now because I use jquerymobile mainly for the gui enhancements. Maybe its because the dialog in this special case is the last entry in history? Normally jquerymobile would skip dialog-history-entries, when you navigate forward or backward e.g. with browserbuttons. But if you navigate forward and the last entry is dialog-hash you can't skip it.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Nov 3, 2011

Contributor

@kenoby - what version of FIrefox and platform are you seeing this on? FF7?

Contributor

toddparker commented Nov 3, 2011

@kenoby - what version of FIrefox and platform are you seeing this on? FF7?

@kenoby

This comment has been minimized.

Show comment
Hide comment
@kenoby

kenoby Nov 4, 2011

FF 7.0.1, WinXP 32bit with latest updates.

kenoby commented Nov 4, 2011

FF 7.0.1, WinXP 32bit with latest updates.

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Apr 17, 2012

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Apr 19, 2012

[navigation] Do not change hash nor add history entry when displaying…
… a dialog at a history entry that already has dialogHashKey -- Fixes: #2656

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Apr 20, 2012

gseguin added a commit that referenced this issue Apr 20, 2012

Merge pull request #4131 from gabrielschulhof/unit-test-for-dialog-do…
…uble-hash

[unit tests] Add unit test for dialog double hash fix -- Re: #2656
@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Apr 20, 2012

Contributor

I believe we can close this issue.

Contributor

gabrielschulhof commented Apr 20, 2012

I believe we can close this issue.

@gseguin gseguin closed this Apr 20, 2012

gabrielschulhof added a commit that referenced this issue May 29, 2012

[navigation] Do not change hash nor add history entry when displaying…
… a dialog at a history entry that already has dialogHashKey -- Fixes: #2656
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment