Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Forward history + dialog #2656

Closed
kenoby opened this Issue · 6 comments

6 participants

@kenoby

Steps to reproduce
1. open http://jquerymobile.com/demos/1.0rc1/docs/pages/page-dialogs.html in a new tab in latest firefox
2. click "Open dialog"
3. close dialog via "X" button
4. click history-forward-button of browser => new hash #&ui-state
5. click "Open dialog" => hash #&ui-state=dialog&ui-state=dialog
6. now two clicks on "X" are needed to close dialog

@johnbender johnbender was assigned
@tommedema

Confirmed in Chromium 12.0.742.112 (90304) Ubuntu 10.10.

@toddparker

Can you guys disabled pushState and see if that resolves this issue? There are some quirks with the browser implementations that we note here:
http://jquerymobile.com/test/docs/pages/page-navmodel.html

@kenoby

I can't test it right now because I use jquerymobile mainly for the gui enhancements. Maybe its because the dialog in this special case is the last entry in history? Normally jquerymobile would skip dialog-history-entries, when you navigate forward or backward e.g. with browserbuttons. But if you navigate forward and the last entry is dialog-hash you can't skip it.

@toddparker

@kenoby - what version of FIrefox and platform are you seeing this on? FF7?

@kenoby

FF 7.0.1, WinXP 32bit with latest updates.

@gabrielschulhof gabrielschulhof referenced this issue from a commit in gabrielschulhof/jquery-mobile
@gabrielschulhof gabrielschulhof [navigation] When showing a dialog, do not append dialogHashKey if th…
…e URL already contains it - Fixes: #2656
7966179
@gabrielschulhof gabrielschulhof referenced this issue from a commit in gabrielschulhof/jquery-mobile
@gabrielschulhof gabrielschulhof [navigation] Do not change hash nor add history entry when displaying…
… a dialog at a history entry that already has dialogHashKey -- Fixes: #2656
358f7de
@gabrielschulhof
Collaborator

I believe we can close this issue.

@gseguin gseguin closed this
@gabrielschulhof gabrielschulhof referenced this issue from a commit
@gabrielschulhof gabrielschulhof [navigation] Do not change hash nor add history entry when displaying…
… a dialog at a history entry that already has dialogHashKey -- Fixes: #2656
4b2c62d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.