buttons don't inherit page-theme #2659

Closed
MauriceG opened this Issue Oct 10, 2011 · 8 comments

Comments

Projects
None yet
5 participants
@MauriceG
Contributor

MauriceG commented Oct 10, 2011

Buttons don't inherit neither the theme of the page nor the theme of the content they're in.
Small demo at http://jsfiddle.net/MauriceG/enpaL/
May this behavior is wanted, but link-styled-buttons does inherit the theme, as you can see at the demo.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Oct 10, 2011

Contributor

I see. So inputs and buttons don't inherit the theme, but links do. Thanks for reporting.

Contributor

toddparker commented Oct 10, 2011

I see. So inputs and buttons don't inherit the theme, but links do. Thanks for reporting.

@ghost ghost assigned gseguin Oct 10, 2011

@MauriceG

This comment has been minimized.

Show comment
Hide comment
@MauriceG

MauriceG Oct 10, 2011

Contributor

No, inputs are working well. Just the buttons do not.
Updated: http://jsfiddle.net/MauriceG/enpaL/3/
But it seems #2658 fits this issue as well.

Contributor

MauriceG commented Oct 10, 2011

No, inputs are working well. Just the buttons do not.
Updated: http://jsfiddle.net/MauriceG/enpaL/3/
But it seems #2658 fits this issue as well.

@ghost ghost assigned jblas Oct 12, 2011

@agcolom

This comment has been minimized.

Show comment
Hide comment
@agcolom

agcolom Oct 12, 2011

Member

Hi, Had a look and with the fiddle discovered that the button text gets displayed differently on Safari and Firefox: If the text is too long to display in full, I get the expected ellipsis with Safari, but with Firefox 3.6.20 (Mac OS) the text goes all the way to the edge of the button. Should this be opened as a new issue? I can host screen shot if that helps.

Member

agcolom commented Oct 12, 2011

Hi, Had a look and with the fiddle discovered that the button text gets displayed differently on Safari and Firefox: If the text is too long to display in full, I get the expected ellipsis with Safari, but with Firefox 3.6.20 (Mac OS) the text goes all the way to the edge of the button. Should this be opened as a new issue? I can host screen shot if that helps.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Oct 12, 2011

Contributor

@agcolom - Sure, sounds like a new issue. Thanks!

Contributor

toddparker commented Oct 12, 2011

@agcolom - Sure, sounds like a new issue. Thanks!

@agcolom

This comment has been minimized.

Show comment
Hide comment
Member

agcolom commented Oct 12, 2011

@toddparker This is what I get:
http://users.cscs.wmin.ac.uk/~coloma/ff.tiff for the firefox view and http://users.cscs.wmin.ac.uk/~coloma/safari.tiff for the Safari view.

@jblas

This comment has been minimized.

Show comment
Hide comment
@jblas

jblas Oct 14, 2011

Contributor

@toddparker

Some quick testing and it looks like buttons, headers, and footers don't inherit the specified data-theme placed on a page element.

Contributor

jblas commented Oct 14, 2011

@toddparker

Some quick testing and it looks like buttons, headers, and footers don't inherit the specified data-theme placed on a page element.

@jblas jblas closed this in 2c2be3d Oct 14, 2011

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Oct 15, 2011

Contributor

Nice work @jblas. I can confirm this is fixed from the handy jsfiddle above.

Contributor

toddparker commented Oct 15, 2011

Nice work @jblas. I can confirm this is fixed from the handy jsfiddle above.

@MauriceG

This comment has been minimized.

Show comment
Hide comment
@MauriceG

MauriceG Oct 15, 2011

Contributor

Good job @jblas! Thank you very much!

Contributor

MauriceG commented Oct 15, 2011

Good job @jblas! Thank you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment