Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Dialog reverse transition #2699
@blt - Now I'm not sure that's true. If I navigate here from the docs home (3 pages in), and click on the buttons to try the various dialog transitions, the reverse transitions are all correct using the 'x' button in the header:
If you deep link to this page (or refresh), the back transitions also seem to work so we might have fixed the "first page" issue @jblas.
All those dialog link so have an explicit transition on the link TO the dialog, but they all point to the same dialog page so the back transition is working correctly there (the reverse is used based on the to transiton).
So the links w/o an explicit data-transition use the default dialog transition from the global options. When I created this page yesterday that sets the defaultDialogTransition global option to "flip", the back transition is the reverse of slideleft which is incorrect.
Is this what you're saying: If you override the default dialog transition as a global option, the reverse isn't working right?
Thanks for filing the issue. The fix has landed on the HEAD:
Turns out we were calculating the transition to use AFTER we created a history entry, so only explicit transitions were being recorded. I simply moved the calculation code before the history entry and things work properly now..