Dialog reverse transition #2699

Closed
blq opened this Issue Oct 13, 2011 · 8 comments

Comments

Projects
None yet
3 participants
@blq

blq commented Oct 13, 2011

If you don't explicitly set data-transition for a dialog link the reverse, close, transition defaults to reverse slide instead of fade.

@jblas

This comment has been minimized.

Show comment
Hide comment
@jblas

jblas Oct 13, 2011

Contributor

@blq

I think this only happens when showing a dialog from the first page of the document. @blq, can you confirm if that is what you were doing when you experienced it?

Contributor

jblas commented Oct 13, 2011

@blq

I think this only happens when showing a dialog from the first page of the document. @blq, can you confirm if that is what you were doing when you experienced it?

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Oct 14, 2011

Contributor

I noticed this same issue today when I created the global settings demos. It happened after a reload so it was a dialog from the main page, like @jblas said.

Contributor

toddparker commented Oct 14, 2011

I noticed this same issue today when I created the global settings demos. It happened after a reload so it was a dialog from the main page, like @jblas said.

@blq

This comment has been minimized.

Show comment
Hide comment
@blq

blq Oct 14, 2011

No, happens on all dialogs. Rather it seems to simply be when you press the close button. Otherwise it behaves correctly.

blq commented Oct 14, 2011

No, happens on all dialogs. Rather it seems to simply be when you press the close button. Otherwise it behaves correctly.

@ghost ghost assigned jblas Oct 14, 2011

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Oct 14, 2011

Contributor

@blt - Now I'm not sure that's true. If I navigate here from the docs home (3 pages in), and click on the buttons to try the various dialog transitions, the reverse transitions are all correct using the 'x' button in the header:
http://jquerymobile.com/test/docs/pages/page-dialogs.html

If you deep link to this page (or refresh), the back transitions also seem to work so we might have fixed the "first page" issue @jblas.

Contributor

toddparker commented Oct 14, 2011

@blt - Now I'm not sure that's true. If I navigate here from the docs home (3 pages in), and click on the buttons to try the various dialog transitions, the reverse transitions are all correct using the 'x' button in the header:
http://jquerymobile.com/test/docs/pages/page-dialogs.html

If you deep link to this page (or refresh), the back transitions also seem to work so we might have fixed the "first page" issue @jblas.

@blq

This comment has been minimized.

Show comment
Hide comment
@blq

blq Oct 14, 2011

Well, all those dialog links in the example actually have an explicit data-transition set (see the html, not the doc text). That was my point. It's dialogs that don't have a transition specified (i.e the default) that have this problem.

blq commented Oct 14, 2011

Well, all those dialog links in the example actually have an explicit data-transition set (see the html, not the doc text). That was my point. It's dialogs that don't have a transition specified (i.e the default) that have this problem.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Oct 14, 2011

Contributor

All those dialog link so have an explicit transition on the link TO the dialog, but they all point to the same dialog page so the back transition is working correctly there (the reverse is used based on the to transiton).

So the links w/o an explicit data-transition use the default dialog transition from the global options. When I created this page yesterday that sets the defaultDialogTransition global option to "flip", the back transition is the reverse of slideleft which is incorrect.
http://jquerymobile.com/test/docs/config/dialogTransition.html

Is this what you're saying: If you override the default dialog transition as a global option, the reverse isn't working right?

Contributor

toddparker commented Oct 14, 2011

All those dialog link so have an explicit transition on the link TO the dialog, but they all point to the same dialog page so the back transition is working correctly there (the reverse is used based on the to transiton).

So the links w/o an explicit data-transition use the default dialog transition from the global options. When I created this page yesterday that sets the defaultDialogTransition global option to "flip", the back transition is the reverse of slideleft which is incorrect.
http://jquerymobile.com/test/docs/config/dialogTransition.html

Is this what you're saying: If you override the default dialog transition as a global option, the reverse isn't working right?

@jblas jblas closed this in ab8dead Oct 14, 2011

@jblas

This comment has been minimized.

Show comment
Hide comment
@jblas

jblas Oct 14, 2011

Contributor

@blq

Thanks for filing the issue. The fix has landed on the HEAD:

ab8dead

Turns out we were calculating the transition to use AFTER we created a history entry, so only explicit transitions were being recorded. I simply moved the calculation code before the history entry and things work properly now..

Contributor

jblas commented Oct 14, 2011

@blq

Thanks for filing the issue. The fix has landed on the HEAD:

ab8dead

Turns out we were calculating the transition to use AFTER we created a history entry, so only explicit transitions were being recorded. I simply moved the calculation code before the history entry and things work properly now..

@ghost ghost assigned jblas Oct 14, 2011

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Oct 14, 2011

Contributor

BOOM. Nice work @jblas.

Contributor

toddparker commented Oct 14, 2011

BOOM. Nice work @jblas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment