Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Set a max width on dialogs #2729

Closed
toddparker opened this issue Oct 17, 2011 · 5 comments · Fixed by #2740
Closed

Set a max width on dialogs #2729

toddparker opened this issue Oct 17, 2011 · 5 comments · Fixed by #2740
Milestone

Comments

@toddparker
Copy link
Contributor

Right now, dialogs open to the width of the screen (with a bit of margin) which is great on small screens, but above 500px, the dialogs look odd full width. I think we should add a max-width to make dialogs look better at wider screens. Maybe 600px max?

@MauriceG
Copy link
Contributor

@toddparker
That would be great!
One thing is, what color will the "canvas" behind the dialog will have.
Because the parent page is hidden, it will be white, i think. Not always nice..

And may another suggestion: Adding a directive for "non-native-select-full-size-dialogs"
like data-list-maxwidth for a selectmenu. If set to auto or null, the framework set the
max-width, if set to a px- or %-value, the author determine the width.

@toddparker
Copy link
Contributor Author

There will be the darker page overlay that covers the viewport and the narrower dialog sitting on top.

Good idea to apply this to the full page selects too.

On Oct 17, 2011, at 7:14 PM, "Maurice Gottlieb" reply@reply.github.com wrote:

@toddparker
That would be great!
One thing is, what color will the "canvas" behind the dialog will have.
Because the parent page is hidden, it will be white, i think. Not always nice..

And may another suggestion: Adding a directive for "non-native-select-full-size-dialogs"
like data-list-maxwidth for a selectmenu. If set to auto or null, the framework set the
max-width, if set to a px- or %-value, the author determine the width.

Reply to this email directly or view it on GitHub:
#2729 (comment)

@MauriceG
Copy link
Contributor

@toddparker Good suggestion, as usual ...
@Wilto Works well! Good work and quick as well! btw: i like your Tick Tock :-)

@Wilto
Copy link
Contributor

Wilto commented Oct 18, 2011

Thanks man! It was either that, or an animated .gif of an “under construction” sign—a classic, for sure.

@MauriceG
Copy link
Contributor

@Wilto
The Tick Tock tells us, we have to wait. So much better than a classic under construction! ;-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants