Set a max width on dialogs #2729

Closed
toddparker opened this Issue Oct 17, 2011 · 5 comments

Comments

Projects
None yet
3 participants
@toddparker
Contributor

toddparker commented Oct 17, 2011

Right now, dialogs open to the width of the screen (with a bit of margin) which is great on small screens, but above 500px, the dialogs look odd full width. I think we should add a max-width to make dialogs look better at wider screens. Maybe 600px max?

@MauriceG

This comment has been minimized.

Show comment
Hide comment
@MauriceG

MauriceG Oct 17, 2011

Contributor

@toddparker
That would be great!
One thing is, what color will the "canvas" behind the dialog will have.
Because the parent page is hidden, it will be white, i think. Not always nice..

And may another suggestion: Adding a directive for "non-native-select-full-size-dialogs"
like data-list-maxwidth for a selectmenu. If set to auto or null, the framework set the
max-width, if set to a px- or %-value, the author determine the width.

Contributor

MauriceG commented Oct 17, 2011

@toddparker
That would be great!
One thing is, what color will the "canvas" behind the dialog will have.
Because the parent page is hidden, it will be white, i think. Not always nice..

And may another suggestion: Adding a directive for "non-native-select-full-size-dialogs"
like data-list-maxwidth for a selectmenu. If set to auto or null, the framework set the
max-width, if set to a px- or %-value, the author determine the width.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Oct 17, 2011

Contributor

There will be the darker page overlay that covers the viewport and the narrower dialog sitting on top.

Good idea to apply this to the full page selects too.

On Oct 17, 2011, at 7:14 PM, "Maurice Gottlieb" reply@reply.github.com wrote:

@toddparker
That would be great!
One thing is, what color will the "canvas" behind the dialog will have.
Because the parent page is hidden, it will be white, i think. Not always nice..

And may another suggestion: Adding a directive for "non-native-select-full-size-dialogs"
like data-list-maxwidth for a selectmenu. If set to auto or null, the framework set the
max-width, if set to a px- or %-value, the author determine the width.

Reply to this email directly or view it on GitHub:
#2729 (comment)

Contributor

toddparker commented Oct 17, 2011

There will be the darker page overlay that covers the viewport and the narrower dialog sitting on top.

Good idea to apply this to the full page selects too.

On Oct 17, 2011, at 7:14 PM, "Maurice Gottlieb" reply@reply.github.com wrote:

@toddparker
That would be great!
One thing is, what color will the "canvas" behind the dialog will have.
Because the parent page is hidden, it will be white, i think. Not always nice..

And may another suggestion: Adding a directive for "non-native-select-full-size-dialogs"
like data-list-maxwidth for a selectmenu. If set to auto or null, the framework set the
max-width, if set to a px- or %-value, the author determine the width.

Reply to this email directly or view it on GitHub:
#2729 (comment)

Wilto added a commit to Wilto/jquery-mobile that referenced this issue Oct 18, 2011

@Wilto Wilto closed this in 9fbadb0 Oct 18, 2011

@Wilto Wilto closed this in 112b3f6 Oct 18, 2011

@MauriceG

This comment has been minimized.

Show comment
Hide comment
@MauriceG

MauriceG Oct 18, 2011

Contributor

@toddparker Good suggestion, as usual ...
@Wilto Works well! Good work and quick as well! btw: i like your Tick Tock :-)

Contributor

MauriceG commented Oct 18, 2011

@toddparker Good suggestion, as usual ...
@Wilto Works well! Good work and quick as well! btw: i like your Tick Tock :-)

@Wilto

This comment has been minimized.

Show comment
Hide comment
@Wilto

Wilto Oct 18, 2011

Contributor

Thanks man! It was either that, or an animated .gif of an “under construction” sign—a classic, for sure.

Contributor

Wilto commented Oct 18, 2011

Thanks man! It was either that, or an animated .gif of an “under construction” sign—a classic, for sure.

@MauriceG

This comment has been minimized.

Show comment
Hide comment
@MauriceG

MauriceG Oct 18, 2011

Contributor

@Wilto
The Tick Tock tells us, we have to wait. So much better than a classic under construction! ;-)

Contributor

MauriceG commented Oct 18, 2011

@Wilto
The Tick Tock tells us, we have to wait. So much better than a classic under construction! ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment