New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery UI widget version unknown #2838

Closed
eddiemonge opened this Issue Oct 25, 2011 · 8 comments

Comments

Projects
None yet
5 participants
@eddiemonge
Contributor

eddiemonge commented Oct 25, 2011

jQuery UI's widget file should include its actual version instead of @Version

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Oct 28, 2011

Contributor

Is this a mobile issue or a UI issue?

Contributor

toddparker commented Oct 28, 2011

Is this a mobile issue or a UI issue?

@eddiemonge

This comment has been minimized.

Show comment
Hide comment
@eddiemonge

eddiemonge Oct 28, 2011

Contributor

mobile. we should put which version of UI we grabbed that from

Contributor

eddiemonge commented Oct 28, 2011

mobile. we should put which version of UI we grabbed that from

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Nov 21, 2011

Contributor

Just to be clear: this is the UI widget factory version, right? Think it may have been 1.6, but maybe you can compare to confirm.

Contributor

toddparker commented Nov 21, 2011

Just to be clear: this is the UI widget factory version, right? Think it may have been 1.6, but maybe you can compare to confirm.

@eddiemonge

This comment has been minimized.

Show comment
Hide comment
@eddiemonge

eddiemonge Nov 21, 2011

Contributor

Right, UI widget factory version

Contributor

eddiemonge commented Nov 21, 2011

Right, UI widget factory version

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Aug 9, 2012

Member

This won't be difficult to fix :)

@toddparker @scottgonzalez

I also see "AUTHORS.txt" in the comments (https://github.com/jquery/jquery-mobile/blob/master/js/jquery.ui.widget.js). Is this something that needs to be replaced as well?

Member

jaspermdegroot commented Aug 9, 2012

This won't be difficult to fix :)

@toddparker @scottgonzalez

I also see "AUTHORS.txt" in the comments (https://github.com/jquery/jquery-mobile/blob/master/js/jquery.ui.widget.js). Is this something that needs to be replaced as well?

@ghost ghost assigned jaspermdegroot Aug 9, 2012

@johnbender johnbender closed this in 50029ac Aug 9, 2012

@gseguin

This comment has been minimized.

Show comment
Hide comment
@gseguin

gseguin Aug 9, 2012

Member

@uGoMobi AUTHORS.txt refers to https://github.com/jquery/jquery-ui/blob/1.9.0-beta.1/AUTHORS.txt. We could replace AUTHORS.txt by that URL

Member

gseguin commented Aug 9, 2012

@uGoMobi AUTHORS.txt refers to https://github.com/jquery/jquery-ui/blob/1.9.0-beta.1/AUTHORS.txt. We could replace AUTHORS.txt by that URL

@johnbender

This comment has been minimized.

Show comment
Hide comment
@johnbender

johnbender Aug 9, 2012

Contributor

fixed :D

Contributor

johnbender commented Aug 9, 2012

fixed :D

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Aug 9, 2012

Member

sounds like a good plan :)

Member

jaspermdegroot commented Aug 9, 2012

sounds like a good plan :)

arschmitz added a commit to arschmitz/jquery-mobile that referenced this issue Oct 16, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment