Problem with page display with fixed header and footer in latest #3020

Closed
agcolom opened this Issue Nov 11, 2011 · 6 comments

Projects

None yet

3 participants

@agcolom
Member
agcolom commented Nov 11, 2011

Hi,

With the latest JQM (not RC2), the content background color stops at the end of the content instead of going all the way to the footer. See http://jsfiddle.net/agcolom/zYXLS/3/ (latest version) and compare with http://jsfiddle.net/agcolom/zYXLS/2/ (RC2)

Thanks,

Anne

@toddparker
Contributor

Good catch. We'll take a look now.

@Wilto Wilto was assigned Nov 11, 2011
@hpbuniat hpbuniat pushed a commit to hpbuniat/jquery-mobile that referenced this issue Nov 13, 2011
@Wilto Wilto Fixes #3020 — Theme-dependent backgrounds should be applied only to ‘…
…data-role=content’ within a dialog.
5262c2b
@toddparker
Contributor

@agcolom - we're trying to track so stuff down on themes and now when we look at your two fiddles, they both look ok. Wondering is this issue was due to latest being out of sync?

Can you check to see if you can reproduce this issue on RC2, RC3 or latest?

@toddparker
Contributor

Here is a fiddle running RC3 and it doesn't appear there:
http://jsfiddle.net/zYXLS/7/

Same goes for RC2 and latest. Feel like I'm losing my mind here.

@agcolom
Member
agcolom commented Nov 16, 2011

@toddparker I did check this yesterday with RC3 and the problem does not appear. I still get it with latest, so is latest still out of sync?
The latest: http://jsfiddle.net/agcolom/zYXLS/3/ (shows issue) (with FF 7.0.1 and Safari 5.0.5 both Mac OS)
RC2: http://jsfiddle.net/agcolom/zYXLS/2/ (doesn't show issue)
RC3: http://jsfiddle.net/agcolom/zYXLS/5/ (doesn't show issue)

@agcolom
Member
agcolom commented Nov 16, 2011

The issue shown with a data-theme to the page: http://jsfiddle.net/agcolom/zYXLS/10/ the background restarts after the end of the content.

@Wilto Wilto added a commit that referenced this issue Nov 16, 2011
@Wilto Wilto Correctly addresses #3020 — “Content” elements now correctly apply th…
…emes, but do not inherit the theme set on the overall page.
4c5e85c
@Wilto Wilto closed this Nov 16, 2011
@agcolom
Member
agcolom commented Nov 16, 2011

yep, the issue is now fixed. Thank you :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment