accordion 1.0 final #3100

Closed
Gerald-H opened this Issue Nov 18, 2011 · 15 comments

Projects

None yet

8 participants

@Gerald-H

Tested on Android, iOs and Firefox for windows:

Accordions are not collapsed when clicking an other accordion. so the automatic closing does not get triggerd any more. On RC3 this was still working, but on the final release it stopped working example: http://jquerymobile.com/demos/1.0/docs/content/content-collapsible-set.html

@agcolom
Member
agcolom commented Nov 18, 2011

Yes I can confirm this is happening also on FF for Mac OS. However, the test docs work fine. Also when comparing the two (http://jquerymobile.com/demos/1.0/docs/content/content-collapsible-set.html and http://jquerymobile.com/test/docs/content/content-collapsible-set.html), you'll notice that all the anchors are getting the ui-corner-bottom (and that shouldn't be the case expect for the last collapsible in the set)

@MauriceG
Contributor

Hi @agcolom :-). Same on iPad2 iOS 5 + Safari 5.0 on Win at demos/1.0 but not at latest /test

@agcolom
Member
agcolom commented Nov 18, 2011

Hi @MauriceG :-) yes, It is as though they are collapsibles but not as part of a collapsible-set. Pretty busy today... May have a closer look later if I get a chance...

@johnbender johnbender was assigned Nov 18, 2011
@toddparker
Contributor

Yes, this is a regression. We'll fix this for 1.0.1

@MauriceG
Contributor

mmh, this is odd. My local repo does not show that issue (fresh pulled from master).
The first final 1.0 download (with that tmp-issue inside) does not show that issue here.
And http://jquerymobile.com/test/docs/content/content-collapsible-set.html does not show it also ...
But the actual jQM download show it and I can't see any commit in the repo.

@gseguin
Member
gseguin commented Nov 18, 2011

@MauriceG

commit 3d17a69 most likely fixed it on master.

@jblas
Contributor
jblas commented Nov 18, 2011

@MauriceG

Thanks for the tip. It looks like gseguin's collapsible set decoupling was picked up in the 2nd version of the 1.0 zip, but the actual decoupled collapsible set plugin wasn't included in the zip.

@eddiemonge
Contributor

It is a regression that will be fixed in 1.0.1
The zip file that was up there was the wrong one and now the true 1.0 zip is up. So for 1.0 it was broken

@eddiemonge
Contributor

Ok so this is actually in 1.0. The files that were up were incorrect. The true 1.0 files are now there. @Gerald-H Please retry and close the ticket if they look correct to you.

@agcolom
Member
agcolom commented Nov 18, 2011

Hi All, all seems fine by me. Thanks a lot for fixing :-)

@MauriceG
Contributor

@eddiemonge Hi! (I know, I'm not Gerald-H...)
Good work! The collapsible-sets work again.
But: I've downloaded 1.0 from http://code.jquery.com/mobile/1.0/jquery.mobile-1.0.zip right now (00:05 CET - 15:05 PST).
After unzipping the archive at my webservers jqm-directory there are the js- and css files AND the images folder.
Opening /local-jqm-dir/demos/index.html do not show any icons cause they are searched in a not existent demos/images dir.
Same if opening /local-jqm-home-dir/demos/docs//index.html.
I hope you get me and I hope I did no mistake ...

@eddiemonge
Contributor

Thats an actual issue. Could you open a new issue for that? Im not entirely sure the best way to resolve that.

@MauriceG
Contributor

@eddiemonge ok, I've created two friday-night issues.

@toddparker
Contributor

Ok, so we squared away grouped collapsible issue so I can close this.

BTW - the docs images is also fixed:
#3112

And the duplication issue:
#3109

@toddparker toddparker closed this Nov 19, 2011
@Gerald-H

Downloaded new 1.0 from the site and it is fixed. Thanks for all your reactions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment