Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

Missing comma in Selectmenu plugin open method #3132

Closed
odedbd opened this issue Nov 21, 2011 · 2 comments
Closed

Missing comma in Selectmenu plugin open method #3132

odedbd opened this issue Nov 21, 2011 · 2 comments
Assignees
Milestone

Comments

@odedbd
Copy link

odedbd commented Nov 21, 2011

I hope this is not a dup, I couldn't find it on the issues and it exists in the /test docs.

the line:

tScrollElem = activePage.is( ".ui-native-fixed" ) ? activePage.find( ".ui-content" ) : activePage;

Number 5810 in the /test docs (checked in firebug), should most likely end with a comma, thus-

tScrollElem = activePage.is( ".ui-native-fixed" ) ? activePage.find( ".ui-content" ) : activePage,

Otherwise all following variables (such as scrollTop or btnOffset) are global variable, right? And this can't be intentional. I hope.

@ghost ghost assigned johnbender Nov 22, 2011
@toddparker
Copy link
Contributor

Thanks for the tip, we'll take a look.

@toddparker
Copy link
Contributor

Fixed by this commit: #3304

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants