Skip to content
This repository

Dynamic Page load sample: In-Memory broken in IE7 #3185

Closed
ernieracer opened this Issue · 3 comments

2 participants

ernieracer Kin Blas
ernieracer

The In-Memory dynamic page loading sample is broken in IE7.

it throws the following exception:

SCRIPT1028: Expected identifier, string or number
sample-reuse-page.html, line 22 character 4

link is on the following page:
http://jquerymobile.com/demos/1.0/docs/pages/page-dynamic.html

and points to:
http://jquerymobile.com/test/docs/pages/dynamic-samples/sample-reuse-page.html

The reason is that IE7 doesn't allow trailing commas in object notations.

The following fixes the issue:

change:

var categoryData = {
animals: {
name: "Animals",
description: "All your favorites from aardvarks to zebras.",
items: [
{
name: "Pets",
},
{
name: "Farm Animals",
},
{
name: "Wild Animals",
}
]
...

to:

var categoryData = {
animals: {
name: "Animals",
description: "All your favorites from aardvarks to zebras.",
items: [
{
name: "Pets"
},
{
name: "Farm Animals"
},
{
name: "Wild Animals"
}
]
...

Even though JavaScript does allow trailing commas in objects and arrays (which makes the sample valid JavaScript code for non-IE7 browsers), the JSON specification to my knowledge does not.

I would also fix the sample code on http://jquerymobile.com/demos/1.0/docs/pages/page-dynamic.html .

Daniel

Kin Blas jblas referenced this issue from a commit
Kin Blas Fix for #3185 - Dynamic Page load sample: In-Memory broken in IE7
- Removed trailing commas that choke IE.
ed05ff8
Kin Blas

@ernieracer

Thanks for reporting and figuring it out. Fix landed on the HEAD:

ed05ff8

Kin Blas jblas closed this
ernieracer

No problem, you're welcome Kin, thank you too!

by the way, personally, I would change the docs as well:

http://jquerymobile.com/demos/1.0/docs/pages/page-dynamic.html
https://github.com/jquery/jquery-mobile/blob/master/docs/pages/page-dynamic.html

Daniel

Kin Blas jblas referenced this issue from a commit
Kin Blas Fix for #3185 - Dynamic Page load sample: In-Memory broken in IE7
- Removed trailing commas that choke IE from the docs.
d9983d7
Kin Blas

Hey Daniel,

Thanks for pointing that out to me. Fixed too.

d9983d7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.