keepNative ignored on dialog page #3236

Closed
rogiervandam opened this Issue Dec 8, 2011 · 1 comment

Comments

Projects
None yet
2 participants

I wanted to have some custom markup on a button, so i tried setting

$.mobile.page.prototype.options.keepNative = ".native"

before loading the framework
and applying class .native to the element.

Unfortunately, this is ignored, because the framework searches for
var page = $(target).closest(":jqmData(role='page')").data( "page" ) (line 314)

should be:

var page = $(target).closest(" :jqmData(role='page'), :jqmData(role='dialog')").data( "page" ) (line 314)

Problem is that type (e.g. 'page') and role (e.g. 'dialog') are both controlled via the data-role propery. Another idea would be to use both data-role and data-rel properties on the page being used as a dialog.

Contributor

toddparker commented Dec 15, 2011

As of 1.0 data-role="dialog" isn't supported, Dialogs are shown by virtue of the data-rel="dialog" on the link to them. We are planning on adding support for this role in 1.1 but I'm closing this as an issue because you're trying to access an invalid data-role:
#3276

toddparker closed this Dec 15, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment