Form submit with reverse transition #3247

Closed
khangnguyen opened this Issue Dec 12, 2011 · 4 comments

Comments

Projects
None yet
4 participants
@khangnguyen

According to the documentation, data-direction="reverse" should make the form show up from right to left (reversed transition).
But seems like it is not happening that way, at least in my case (I am using official release 1.0)

I guess the problem is in line 3220
$.mobile.changePage(
url,
{
type: type && type.length && type.toLowerCase() || "get",
data: $this.serialize(),
transition: $this.jqmData( "transition" ),
direction: $this.jqmData( "direction" ),
reloadPage: true
}
);

these options are then merged with settings in changePage(). The settings use the key "reverse" (bool) to determine the transition direction, not "direction"

Hope this help

@johnbender

This comment has been minimized.

Show comment
Hide comment
@johnbender

johnbender Dec 12, 2011

Contributor

Pull request to fix this is under review:

#3220

Contributor

johnbender commented Dec 12, 2011

Pull request to fix this is under review:

#3220

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Dec 12, 2011

Contributor

Great @johnbender - Looks like there isn't an issue associated with that pull so I should leave this open.

Contributor

toddparker commented Dec 12, 2011

Great @johnbender - Looks like there isn't an issue associated with that pull so I should leave this open.

@irnc

This comment has been minimized.

Show comment
Hide comment
@irnc

irnc Dec 12, 2011

Contributor

@toddparker There is also a duplicate issue #2367

Contributor

irnc commented Dec 12, 2011

@toddparker There is also a duplicate issue #2367

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Dec 12, 2011

Contributor

Good point @irnc - closing as duplicate of #2367

Contributor

toddparker commented Dec 12, 2011

Good point @irnc - closing as duplicate of #2367

@toddparker toddparker closed this Dec 12, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment