New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation error under data-attributes - Header - data-title #3259

Closed
chetankjain opened this Issue Dec 13, 2011 · 6 comments

Comments

Projects
None yet
3 participants
@chetankjain
Contributor

chetankjain commented Dec 13, 2011

http://jquerymobile.com/demos/1.0/docs/api/data-attributes.html
has the data-title attribute listed under Header, but I couldn't get it working

Even http://jquerymobile.com/demos/1.0/docs/toolbars/docs-headers.html
doesn't have any reference to a data-title attribute, so is this a documentation bug under data-attributes?

@agcolom

This comment has been minimized.

Show comment
Hide comment
@agcolom

agcolom Dec 15, 2011

Member

Yes, thanks for pointing this out. The data-tile goes in the page (div with data-role="page").

Member

agcolom commented Dec 15, 2011

Yes, thanks for pointing this out. The data-tile goes in the page (div with data-role="page").

@chetankjain

This comment has been minimized.

Show comment
Hide comment
@chetankjain

chetankjain Dec 16, 2011

Contributor

Great for taking this up and thanks

Contributor

chetankjain commented Dec 16, 2011

Great for taking this up and thanks

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Dec 16, 2011

Contributor

Just pulled this in.

Contributor

toddparker commented Dec 16, 2011

Just pulled this in.

@toddparker toddparker closed this Dec 16, 2011

@agcolom

This comment has been minimized.

Show comment
Hide comment
@agcolom

agcolom Dec 16, 2011

Member

Thanks :-) I think #3265 can also be closed.

Member

agcolom commented Dec 16, 2011

Thanks :-) I think #3265 can also be closed.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Dec 16, 2011

Contributor

Great, just closed. If you include "Fixes #0000" in the commit, it should auto close when pulled in. I've been tagging issues with "Docs" for you to keep an eye on going forward.

Contributor

toddparker commented Dec 16, 2011

Great, just closed. If you include "Fixes #0000" in the commit, it should auto close when pulled in. I've been tagging issues with "Docs" for you to keep an eye on going forward.

@agcolom

This comment has been minimized.

Show comment
Hide comment
@agcolom

agcolom Dec 16, 2011

Member

Thanks, I'll use that in future. Yes, having the Docs tag is really useful also.

Member

agcolom commented Dec 16, 2011

Thanks, I'll use that in future. Yes, having the Docs tag is really useful also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment