New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar buttons should truncate text to avoid overlap #3262

Closed
offsky opened this Issue Dec 13, 2011 · 1 comment

Comments

Projects
None yet
2 participants
@offsky

offsky commented Dec 13, 2011

If the buttons in a toolbar have really long text, they can overlap the title, or each other, and become unusable.

http://jsfiddle.net/axVBG/

The solution is to truncate the button text with ellipses if they would overlap the centered title. Perhaps you could assign each button and the title 1/3 of the width and truncate any excess.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Dec 14, 2011

Contributor

Good idea. I guess we can set a max width and overflow from there.

Contributor

toddparker commented Dec 14, 2011

Good idea. I guess we can set a max width and overflow from there.

garann added a commit to garann/jquery-mobile that referenced this issue Dec 25, 2011

garann added a commit to garann/jquery-mobile that referenced this issue Dec 27, 2011

Wilto added a commit that referenced this issue Dec 29, 2011

Merge pull request #3344 from garann/master
Corrected fix for #3262 so it doesn't prevent buttons filling available space.

@toddparker toddparker closed this Jan 3, 2012

scottjehl pushed a commit that referenced this issue Jan 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment