New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a failsafe if people use data-role="dialog" #3275

Closed
toddparker opened this Issue Dec 15, 2011 · 3 comments

Comments

Projects
None yet
4 participants
@toddparker
Contributor

toddparker commented Dec 15, 2011

We're seeing some people try and use data-role="dialog" which isn't a valid role yet in the framework. You make a dialog by linking with data-rel="dialog" on a link but in non-ajax situations, people must be trying this instead.

The dialog role results in a blank page because it's not valid. As a first step, we can look for data-role="dialog"`` and change it todata-role="page"`` so at least the page renders.

In an upcoming update, we can try and truly support this role so the page renders as a dialog. I'll make a separate ticket for that.

@chetankjain

This comment has been minimized.

Show comment
Hide comment
@chetankjain

chetankjain Dec 17, 2011

Contributor

I think this issue can be closed as duplicate of Issue #3276 ?

Contributor

chetankjain commented Dec 17, 2011

I think this issue can be closed as duplicate of Issue #3276 ?

@tehraven

This comment has been minimized.

Show comment
Hide comment
@tehraven

tehraven Dec 18, 2011

If you're going to make an exception for people who are making this error, wouldn't it make sense to treat all invalid data-role types as "page"?

tehraven commented Dec 18, 2011

If you're going to make an exception for people who are making this error, wouldn't it make sense to treat all invalid data-role types as "page"?

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Dec 19, 2011

Contributor

I don't think so. This is more of a temporary fix until the data role is properly supported. Since you can only have one data-role of page at a time in a view, it would be dangerous to assume that an unknown role is a page.

Contributor

toddparker commented Dec 19, 2011

I don't think so. This is more of a temporary fix until the data role is properly supported. Since you can only have one data-role of page at a time in a view, it would be dangerous to assume that an unknown role is a page.

gabrielschulhof pushed a commit to gabrielschulhof/jquery-mobile that referenced this issue Jan 17, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment