Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

WP7 border-radius CSS performance issue #3288

Closed
sgrebnov opened this Issue Dec 16, 2011 · 3 comments

Comments

Projects
None yet
2 participants
Contributor

sgrebnov commented Dec 16, 2011

More details and initial issue discussion available here:
https://filamentgroup.basecamphq.com/projects/8580955-jquery-mobile-team/posts/55498494/comments

I found out that custom selectmenu could be hardly used on WP7 if it contains more than 10 menut items- it is opened very slowly (about 6 sec for menu with 50 items) and it takes about 7-8 sec to display next items after scrolling. You can reproduce this behavior using links below:

I found out that custom selectmenu is opened in a dialog page which uses dialog footer with the following CSS class “.ui-corner-bottom” and which causes the performance issue. When I disable CSS properties border-bottom-left-radius and border-bottom-right-radius of this class custom selectmenu is opened and scrolled very well. You can check updated version here: http://m.akvelon.net:8182/55b/index.html .

I see that the dialog header also applies similar CSS properties (border-top-left-radius and border-top-right-radius) but it doesn’t affect the performance.

Contributor

sgrebnov commented Dec 16, 2011

Same performance issue on WP7 when we add listview control to dialog page and open it. You can check it here - http://m.akvelon.net:8182/55c/

Contributor

sgrebnov commented Dec 16, 2011

I propose the following fix(s):

  1. For custom selectmenu:
    Remove ui-corner-bottom css style for the dialog control when menu open() function is called.
  2. For dialog page + listview combination:
    To fix it we can look for ‘listview’ controls in dialog _create() function. If at least one control is found we don’t apply ‘ui-corner-bottom’ class.

PS. There is also a super easy fix to just remove 'ui-corner-bottom' style for dialog at all. But I don't like it because rounded corners work well and look good for other dialogs.

sgrebnov pushed a commit to sgrebnov/jquery-mobile that referenced this issue Dec 16, 2011

sgrebnov pushed a commit to sgrebnov/jquery-mobile that referenced this issue Dec 27, 2011

@ghost ghost assigned jaspermdegroot May 2, 2013

Member

jaspermdegroot commented Jun 13, 2013

Closing as fixed by commit 4973827.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment