New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitions in a multi-page template with data-ajax=false #3296

Closed
chetankjain opened this Issue Dec 17, 2011 · 8 comments

Comments

Projects
None yet
4 participants
@chetankjain
Contributor

chetankjain commented Dec 17, 2011

http://jquerymobile.com/demos/1.0/docs/pages/page-links.html
does not talk about transitions in a multi-page template application when data-ajax="false"

  1. Here the DOM is definitely not reloaded.
  2. Only the default slide transition works, even if you specify any other data-transition
  3. If a Dialog is launched by data-rel="dialog", again only slide transition works (not pop), even if you specify data-transition="pop"
  4. If a Dialog is launched using data-role="dialog", then the transition used is "pop" and any value set in the data-transition attribute is ignored

Are the above behavior implemented as expected and only the docs need to be updated?
Or
Should JQM ignore data-ajax="false" in multi-page template scenario?

@chetankjain

This comment has been minimized.

Show comment
Hide comment
@chetankjain
Contributor

chetankjain commented Dec 19, 2011

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Dec 19, 2011

Contributor

I see the issue, but why are you adding data-ajax="false" to internal page links anyway? We should fix this, but it seems unnecessary.

Contributor

toddparker commented Dec 19, 2011

I see the issue, but why are you adding data-ajax="false" to internal page links anyway? We should fix this, but it seems unnecessary.

@chetankjain

This comment has been minimized.

Show comment
Hide comment
@chetankjain

chetankjain Dec 19, 2011

Contributor

Yes I agree that it is not necessary. It was only to demonstrate this behavior.

Contributor

chetankjain commented Dec 19, 2011

Yes I agree that it is not necessary. It was only to demonstrate this behavior.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Dec 19, 2011

Contributor

But if this isn't a situation you'd ever use, it's sort of an extreme edge case.

Contributor

toddparker commented Dec 19, 2011

But if this isn't a situation you'd ever use, it's sort of an extreme edge case.

@bdeterling

This comment has been minimized.

Show comment
Hide comment
@bdeterling

bdeterling Mar 2, 2012

Here's a reason I have to use it. I want to use a mailto in my app. On IOS in fullscreen/standalone mode, mailto links do not work. So my workaround is to reload the page using data-ajax="false" which should open the page in non-standalone Safari; then do window.location = 'mailto...'. It's not ideal but it works when I set the original link to a full URL. I'd just like to be able to reload the current page from the server rather than have to put a full URL in the original link.

I would be ecstatic if you said there's a much easier way to use mailto from standalone mode so I don't need this.

Update: turns out it was only a problem in the simulator. So I guess this is an extreme edge case after all.

bdeterling commented Mar 2, 2012

Here's a reason I have to use it. I want to use a mailto in my app. On IOS in fullscreen/standalone mode, mailto links do not work. So my workaround is to reload the page using data-ajax="false" which should open the page in non-standalone Safari; then do window.location = 'mailto...'. It's not ideal but it works when I set the original link to a full URL. I'd just like to be able to reload the current page from the server rather than have to put a full URL in the original link.

I would be ecstatic if you said there's a much easier way to use mailto from standalone mode so I don't need this.

Update: turns out it was only a problem in the simulator. So I guess this is an extreme edge case after all.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Jul 16, 2012

Member

@toddparker

I don't know if it is easy to make navigation.js ignore data-ajax="false" in case of linking inside a multipage template. Do you agree about a line in the docs that says you shouldn't add it because it is useless and interferes with transition settings?

If so, @chetankjain do you mind creating a PR for it?

Thanks!

Member

jaspermdegroot commented Jul 16, 2012

@toddparker

I don't know if it is easy to make navigation.js ignore data-ajax="false" in case of linking inside a multipage template. Do you agree about a line in the docs that says you shouldn't add it because it is useless and interferes with transition settings?

If so, @chetankjain do you mind creating a PR for it?

Thanks!

@chetankjain

This comment has been minimized.

Show comment
Hide comment
@chetankjain

chetankjain Jul 16, 2012

Contributor

@uGoMobi proposing this patch. Let me know if OK ...

Contributor

chetankjain commented Jul 16, 2012

@uGoMobi proposing this patch. Let me know if OK ...

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Jul 16, 2012

Member

@chetankjain - It's perfect. Thanks a lot!

Member

jaspermdegroot commented Jul 16, 2012

@chetankjain - It's perfect. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment