Close icon of dialog doesn't work with $.mobile.defaultDialogTransition set to "none" #3351

Closed
Mowd opened this Issue Dec 29, 2011 · 2 comments

Comments

Projects
None yet
4 participants
@Mowd

Mowd commented Dec 29, 2011

Due to performance issue I set transition to none.
$.mobile.defaultPageTransition = "none";
$.mobile.defaultDialogTransition = "none";

And there's problem on my Android device 2.3.6 when I use close icon (X) to close the dialog, the dialog will close, but it will re-open again.
Sometimes it also happened on iOS device.
It's normal when I remove $.mobile.defaultDialogTransition = "none", but the transition effect is very laggy.

@imjoshdean

This comment has been minimized.

Show comment
Hide comment
@imjoshdean

imjoshdean Jan 7, 2012

I am able to reproduce this on iOS5 with this code: http://jsbin.com/ebofab/

I had a similar issue in a web site I am making. It's because the close dialog uses the virtual mouse click "vclick" rather than the normal "click" event. Essentially your tap is being placed on the close button and the thing that opens the dialog at the same time.

The reason removing $.mobile.defaultDialogTransition = "none"; works is because the dialog doesn't immediately disappear.

Going to make a pull request switching the close button from using vclick to click.

I am able to reproduce this on iOS5 with this code: http://jsbin.com/ebofab/

I had a similar issue in a web site I am making. It's because the close dialog uses the virtual mouse click "vclick" rather than the normal "click" event. Essentially your tap is being placed on the close button and the thing that opens the dialog at the same time.

The reason removing $.mobile.defaultDialogTransition = "none"; works is because the dialog doesn't immediately disappear.

Going to make a pull request switching the close button from using vclick to click.

@johnbender

This comment has been minimized.

Show comment
Hide comment
@johnbender

johnbender Jan 16, 2012

Contributor

@imjoshdean

I'm not seeing the pull request you referred to in IRC.

@jblas

This looks like the delay issue from vclick. Have you any issue with switching over to click for this, with a comment as to why?

Contributor

johnbender commented Jan 16, 2012

@imjoshdean

I'm not seeing the pull request you referred to in IRC.

@jblas

This looks like the delay issue from vclick. Have you any issue with switching over to click for this, with a comment as to why?

imjoshdean pushed a commit to imjoshdean/jquery-mobile that referenced this issue Jan 17, 2012

gseguin added a commit that referenced this issue Jan 19, 2012

Merge pull request #3441 from imjoshdean/fix-3351
Fix to #3351, dialogs reopening when attempting to close them

@gseguin gseguin closed this Jan 19, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment