Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Close icon of dialog doesn't work with $.mobile.defaultDialogTransition set to "none" #3351

Closed
Mowd opened this Issue · 2 comments

4 participants

Mowd Josh Dean John Bender Ghislain Seguin
Mowd

Due to performance issue I set transition to none.
$.mobile.defaultPageTransition = "none";
$.mobile.defaultDialogTransition = "none";

And there's problem on my Android device 2.3.6 when I use close icon (X) to close the dialog, the dialog will close, but it will re-open again.
Sometimes it also happened on iOS device.
It's normal when I remove $.mobile.defaultDialogTransition = "none", but the transition effect is very laggy.

Josh Dean

I am able to reproduce this on iOS5 with this code: http://jsbin.com/ebofab/

I had a similar issue in a web site I am making. It's because the close dialog uses the virtual mouse click "vclick" rather than the normal "click" event. Essentially your tap is being placed on the close button and the thing that opens the dialog at the same time.

The reason removing $.mobile.defaultDialogTransition = "none"; works is because the dialog doesn't immediately disappear.

Going to make a pull request switching the close button from using vclick to click.

John Bender

@imjoshdean

I'm not seeing the pull request you referred to in IRC.

@jblas

This looks like the delay issue from vclick. Have you any issue with switching over to click for this, with a comment as to why?

Josh Dean imjoshdean referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
Josh Dean imjoshdean referenced this issue from a commit in imjoshdean/jquery-mobile
Josh Dean Fix to #3351, dialogs reopening when attempting to close them 240505a
Ghislain Seguin gseguin closed this
Rob Schieber sheebz referenced this issue from a commit
Rob Schieber sheebz Fixes commit #3351 - 87db1cf. This breaks any widget e.g. datebox whi…
…ch was firing vclick events to close dialog. In addition, jquery mobile enables fastclick (vclick) out of the box, see useFastClick, the documentation actually advises that disabling will break widgets.
f161355
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.