Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

getTopOffset() should subtract scrollTop not add it. #3416

Closed
jblas opened this Issue Jan 11, 2012 · 0 comments

Comments

Projects
None yet
1 participant
Contributor

jblas commented Jan 11, 2012

While reading the code for getTopOffset() in jquery.mobile.fixheaderfooter.js I noticed that we are adding op.scrollTop to the top running total when we should be subracting it.

Luckily fixed headers/footers are only allowed in pages which are absolutely positioned at (0,0) within the viewport which means we never see the bug. This may change when we start supporting tablet UI patterns.

@ghost ghost assigned jblas Jan 11, 2012

jblas added a commit that referenced this issue Jan 11, 2012

Fix for issue #3416 - getTopOffset() should subtract scrollTop not ad…
…d it.

- Modified private utility function getTopOffset() so that it subracts scrollTop from top instead of adding it.

@jblas jblas closed this Jan 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment