Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

getTopOffset() should subtract scrollTop not add it. #3416

Closed
jblas opened this Issue · 0 comments

1 participant

@jblas

While reading the code for getTopOffset() in jquery.mobile.fixheaderfooter.js I noticed that we are adding op.scrollTop to the top running total when we should be subracting it.

Luckily fixed headers/footers are only allowed in pages which are absolutely positioned at (0,0) within the viewport which means we never see the bug. This may change when we start supporting tablet UI patterns.

@jblas jblas was assigned
@jblas jblas referenced this issue from a commit
@jblas jblas Fix for issue #3416 - getTopOffset() should subtract scrollTop not ad…
…d it.

- Modified private utility function getTopOffset() so that it subracts scrollTop from top instead of adding it.
86f74cb
@jblas jblas closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.