Need to update js/jquery.ui.widget.js #3544

Closed
gabrielschulhof opened this Issue Feb 6, 2012 · 5 comments

Comments

Projects
None yet
2 participants
@gabrielschulhof
Contributor

gabrielschulhof commented Feb 6, 2012

There's another reason we need to update the widget base class:

It seems that, when you subclass a widget, objects declared in the superclass' prototype and overriden in the subclass' prototype clobber the objects in the superclass' prototype upon getting overridden.

Please have a look at this for an example. If you replace the link to jqm master's version of jquery.ui.widget.js with that of juery UI's master, the subclassing will start to work properly.

@gseguin

This comment has been minimized.

Show comment
Hide comment
@gseguin

gseguin Feb 6, 2012

Member

I just dropped jquery.ui.widget.js 1.8.17 into our source tree and tests are passing so 👍 to upgrading to the latest version of this component.

Member

gseguin commented Feb 6, 2012

I just dropped jquery.ui.widget.js 1.8.17 into our source tree and tests are passing so 👍 to upgrading to the latest version of this component.

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Feb 7, 2012

Contributor

Unfortunately 1.8.17 does not contain that fix.

Contributor

gabrielschulhof commented Feb 7, 2012

Unfortunately 1.8.17 does not contain that fix.

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Feb 7, 2012

Contributor

This bug is fixed in the following jquery-ui commit: b915325

Contributor

gabrielschulhof commented Feb 7, 2012

This bug is fixed in the following jquery-ui commit: b915325

@gseguin

This comment has been minimized.

Show comment
Hide comment
@gseguin

gseguin Feb 7, 2012

Member

So which version of jquery-ui is that? It looks like that commit is pretty old.

Member

gseguin commented Feb 7, 2012

So which version of jquery-ui is that? It looks like that commit is pretty old.

@gabrielschulhof

This comment has been minimized.

Show comment
Hide comment
@gabrielschulhof

gabrielschulhof Feb 7, 2012

Contributor

It is in 1.9m5 ... 1.9m4 is still broken. My guess is that while the commit may be old, they never tagged any of its descendents as 1.8.x, because they're saving it for 1.9.

I did a checkout of 1.9m4 vs. 1.9m5 and it is indeed broken in 1.9m4 whereas it is fixed in 1.9m5.

Contributor

gabrielschulhof commented Feb 7, 2012

It is in 1.9m5 ... 1.9m4 is still broken. My guess is that while the commit may be old, they never tagged any of its descendents as 1.8.x, because they're saving it for 1.9.

I did a checkout of 1.9m4 vs. 1.9m5 and it is indeed broken in 1.9m4 whereas it is fixed in 1.9m5.

gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Apr 16, 2012

gseguin added a commit that referenced this issue Apr 16, 2012

Merge pull request #4054 from gabrielschulhof/updated-jquery-ui-widget
[widget] Took widget from jQuery UI 1.9m7 - Fixes: #3544
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment