Skip to content
This repository

Need to update js/jquery.ui.widget.js #3544

Closed
gabrielschulhof opened this Issue February 06, 2012 · 5 comments

2 participants

Gabriel "_|Nix|_" Schulhof Ghislain Seguin
Gabriel "_|Nix|_" Schulhof
Collaborator

There's another reason we need to update the widget base class:

It seems that, when you subclass a widget, objects declared in the superclass' prototype and overriden in the subclass' prototype clobber the objects in the superclass' prototype upon getting overridden.

Please have a look at this for an example. If you replace the link to jqm master's version of jquery.ui.widget.js with that of juery UI's master, the subclassing will start to work properly.

Ghislain Seguin
Collaborator

I just dropped jquery.ui.widget.js 1.8.17 into our source tree and tests are passing so :+1: to upgrading to the latest version of this component.

Gabriel "_|Nix|_" Schulhof
Collaborator

Unfortunately 1.8.17 does not contain that fix.

Gabriel "_|Nix|_" Schulhof
Collaborator

This bug is fixed in the following jquery-ui commit: b915325

Ghislain Seguin
Collaborator

So which version of jquery-ui is that? It looks like that commit is pretty old.

Gabriel "_|Nix|_" Schulhof
Collaborator

It is in 1.9m5 ... 1.9m4 is still broken. My guess is that while the commit may be old, they never tagged any of its descendents as 1.8.x, because they're saving it for 1.9.

I did a checkout of 1.9m4 vs. 1.9m5 and it is indeed broken in 1.9m4 whereas it is fixed in 1.9m5.

Gabriel "_|Nix|_" Schulhof gabrielschulhof referenced this issue from a commit in gabrielschulhof/jquery-mobile April 16, 2012
Gabriel "_|Nix|_" Schulhof [widget] Took widget from jQuery UI 1.9m7 - Fixes: #3544 63dc7b2
Gabriel "_|Nix|_" Schulhof gabrielschulhof closed this April 16, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.