New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enhancement after manipulating button state #3635

Closed
itsnotvalid opened this Issue Feb 24, 2012 · 7 comments

Comments

Projects
None yet
5 participants
@itsnotvalid

itsnotvalid commented Feb 24, 2012

Tested on [c5f0eb3]. With a call to .buttonMarkup() on a jQuery object that is correctly enhanced as a grouped button, it would fall back to a button with rounded corners.

Follow up: a quick fix would be executing .controlgroup() on the block level element enclosing this button.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Feb 27, 2012

Contributor

Can you post a test page using the latest js and css? Template: http://jsbin.com/efufoy/edit

Contributor

toddparker commented Feb 27, 2012

Can you post a test page using the latest js and css? Template: http://jsbin.com/efufoy/edit

@itsnotvalid

This comment has been minimized.

Show comment
Hide comment
@itsnotvalid

itsnotvalid Feb 28, 2012

http://jsbin.com/uwuniy

Also included workaround for #3637.

itsnotvalid commented Feb 28, 2012

http://jsbin.com/uwuniy

Also included workaround for #3637.

@asgeo1

This comment has been minimized.

Show comment
Hide comment
@asgeo1

asgeo1 Apr 2, 2012

+1 having this same issue

But calling .controlgroup() will only fix it if the control group is visible on the page. For some reason it does nothing if the control group is hidden.

asgeo1 commented Apr 2, 2012

+1 having this same issue

But calling .controlgroup() will only fix it if the control group is visible on the page. For some reason it does nothing if the control group is hidden.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot May 23, 2012

Member

@itsnotvalid - When I look at your JSBin I don't see an issue. Can you confirm this is fixed? Same goes for #3637

Member

jaspermdegroot commented May 23, 2012

@itsnotvalid - When I look at your JSBin I don't see an issue. Can you confirm this is fixed? Same goes for #3637

@itsnotvalid

This comment has been minimized.

Show comment
Hide comment
@itsnotvalid

itsnotvalid May 23, 2012

@uGoMobi please look at the source of that JSBin, I actually did two workarounds to make it work as expected. I shouldn't need to call .controlgroup() to get it repainted (and .trigger('vmouseout') for #3637). Not sure I am am abusing anything here, though.

itsnotvalid commented May 23, 2012

@uGoMobi please look at the source of that JSBin, I actually did two workarounds to make it work as expected. I shouldn't need to call .controlgroup() to get it repainted (and .trigger('vmouseout') for #3637). Not sure I am am abusing anything here, though.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot May 23, 2012

Member

@itsnotvalid

Sorry, I should have read better before looking at the JSBin.
I agree that we have to look into re-enhancement after manipulating the state.
Besides that we are going to add examples to the docs that show what functions to use for manipulating, etc.. (#4389)
If you don't mind I change the topic of this issue to a more general one and close #3637. Will look at both examples in your fiddle while working on the issue.

Jasper

Note: The delete icon seems a bit misaligned. We need to check this.

Member

jaspermdegroot commented May 23, 2012

@itsnotvalid

Sorry, I should have read better before looking at the JSBin.
I agree that we have to look into re-enhancement after manipulating the state.
Besides that we are going to add examples to the docs that show what functions to use for manipulating, etc.. (#4389)
If you don't mind I change the topic of this issue to a more general one and close #3637. Will look at both examples in your fiddle while working on the issue.

Jasper

Note: The delete icon seems a bit misaligned. We need to check this.

@ghost ghost assigned jaspermdegroot May 23, 2012

@itsnotvalid

This comment has been minimized.

Show comment
Hide comment
@itsnotvalid

itsnotvalid May 25, 2012

Thank you please go ahead. I would be notified anyways.

itsnotvalid commented May 25, 2012

Thank you please go ahead. I would be notified anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment