Skip to content

document size with fixed toolbars #3694

Closed
DGuidi opened this Issue Mar 1, 2012 · 9 comments

5 participants

@DGuidi
DGuidi commented Mar 1, 2012

This is a page stub with 1.0.1: http://jsfiddle.net/D_Guidi/4NwuG/
the same stub using 1.1.0 RC1: http://jsfiddle.net/D_Guidi/MwYAf/
As you can see, the size of the page is bigger than the viewport.

@Henkeh
Henkeh commented Mar 1, 2012

This issue has already been addressed, see #3663.
Make sure you use the latest versions of jqm as suggested by the template, see here the resulting jsfiddle.
However the issue that the viewport expands one pixel when clicked upon, as suggested here, remains..

@DGuidi
DGuidi commented Mar 1, 2012

thanks a lot. I've checked a bit of someone already submitted this issue, but without success.

@agcolom
jQuery Foundation member
agcolom commented Mar 1, 2012

I belive this is fixed in latest build (http://jsfiddle.net/agcolom/MwYAf/4/show/) To view the code: http://jsfiddle.net/agcolom/MwYAf/4/

Anne

@DGuidi
DGuidi commented Mar 2, 2012

thanks again

@agcolom
jQuery Foundation member
agcolom commented Mar 6, 2012

@Wilto I thought this was fixed but now if you look at http://jsfiddle.net/agcolom/MwYAf/4/show/ and click , some scrollbars appear (for about an extra 1pixel)

@agcolom
jQuery Foundation member
agcolom commented Mar 6, 2012

The problem comes from

    .ui-footer-fixed {
        bottom: -1px;
        padding-bottom: 1px;
    }

-1px needs to be replaced with 0. Any reason for the -1px?
cc: @Wilto @toddparker @scottjehl @johnbender

@Wilto
Wilto commented Mar 6, 2012

Yep, that one’s on me. I was trying to work around the 1px jitter on the fixed footers—we’ve seen it in a handful of browsers. This way, it wasn’t as noticeable where the -1px kept one pixel of the background from showing through. Back to the drawing board on this one.

@Wilto Wilto added a commit that closed this issue Mar 6, 2012
@Wilto Wilto Fixes #3694 — `bottom: -1px; padding-bottom: 1px` on fixed footer, pr…
…eviously used to hide 1px “jitter” seen in many browsers during scroll, was triggering scrollbars in some browsers.
f8a4744
@Wilto Wilto closed this in f8a4744 Mar 6, 2012
@scottjehl
@agcolom
jQuery Foundation member
agcolom commented Mar 6, 2012

Beautiful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.