New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document size with fixed toolbars #3694

Closed
DGuidi opened this Issue Mar 1, 2012 · 9 comments

Comments

Projects
None yet
5 participants
@DGuidi

DGuidi commented Mar 1, 2012

This is a page stub with 1.0.1: http://jsfiddle.net/D_Guidi/4NwuG/
the same stub using 1.1.0 RC1: http://jsfiddle.net/D_Guidi/MwYAf/
As you can see, the size of the page is bigger than the viewport.

@Henkeh

This comment has been minimized.

Show comment
Hide comment
@Henkeh

Henkeh Mar 1, 2012

This issue has already been addressed, see #3663.
Make sure you use the latest versions of jqm as suggested by the template, see here the resulting jsfiddle.
However the issue that the viewport expands one pixel when clicked upon, as suggested here, remains..

Henkeh commented Mar 1, 2012

This issue has already been addressed, see #3663.
Make sure you use the latest versions of jqm as suggested by the template, see here the resulting jsfiddle.
However the issue that the viewport expands one pixel when clicked upon, as suggested here, remains..

@DGuidi

This comment has been minimized.

Show comment
Hide comment
@DGuidi

DGuidi Mar 1, 2012

thanks a lot. I've checked a bit of someone already submitted this issue, but without success.

DGuidi commented Mar 1, 2012

thanks a lot. I've checked a bit of someone already submitted this issue, but without success.

@agcolom

This comment has been minimized.

Show comment
Hide comment
@agcolom

agcolom Mar 1, 2012

Member

I belive this is fixed in latest build (http://jsfiddle.net/agcolom/MwYAf/4/show/) To view the code: http://jsfiddle.net/agcolom/MwYAf/4/

Anne

Member

agcolom commented Mar 1, 2012

I belive this is fixed in latest build (http://jsfiddle.net/agcolom/MwYAf/4/show/) To view the code: http://jsfiddle.net/agcolom/MwYAf/4/

Anne

@DGuidi

This comment has been minimized.

Show comment
Hide comment
@DGuidi

DGuidi Mar 2, 2012

thanks again

DGuidi commented Mar 2, 2012

thanks again

@agcolom

This comment has been minimized.

Show comment
Hide comment
@agcolom

agcolom Mar 6, 2012

Member

@Wilto I thought this was fixed but now if you look at http://jsfiddle.net/agcolom/MwYAf/4/show/ and click , some scrollbars appear (for about an extra 1pixel)

Member

agcolom commented Mar 6, 2012

@Wilto I thought this was fixed but now if you look at http://jsfiddle.net/agcolom/MwYAf/4/show/ and click , some scrollbars appear (for about an extra 1pixel)

@agcolom

This comment has been minimized.

Show comment
Hide comment
@agcolom

agcolom Mar 6, 2012

Member

The problem comes from

    .ui-footer-fixed {
        bottom: -1px;
        padding-bottom: 1px;
    }

-1px needs to be replaced with 0. Any reason for the -1px?
cc: @Wilto @toddparker @scottjehl @johnbender

Member

agcolom commented Mar 6, 2012

The problem comes from

    .ui-footer-fixed {
        bottom: -1px;
        padding-bottom: 1px;
    }

-1px needs to be replaced with 0. Any reason for the -1px?
cc: @Wilto @toddparker @scottjehl @johnbender

@Wilto

This comment has been minimized.

Show comment
Hide comment
@Wilto

Wilto Mar 6, 2012

Contributor

Yep, that one’s on me. I was trying to work around the 1px jitter on the fixed footers—we’ve seen it in a handful of browsers. This way, it wasn’t as noticeable where the -1px kept one pixel of the background from showing through. Back to the drawing board on this one.

Contributor

Wilto commented Mar 6, 2012

Yep, that one’s on me. I was trying to work around the 1px jitter on the fixed footers—we’ve seen it in a handful of browsers. This way, it wasn’t as noticeable where the -1px kept one pixel of the background from showing through. Back to the drawing board on this one.

@Wilto Wilto closed this in f8a4744 Mar 6, 2012

@scottjehl

This comment has been minimized.

Show comment
Hide comment
@scottjehl

scottjehl Mar 6, 2012

Contributor

This is back to bottom: 0; now. Should we close out?

On Mar 6, 2012, at 10:02 PM, Mat Marquis wrote:

Yep, that one’s on me. I was trying to work around the 1px jitter on the fixed footers—we’ve seen it in a handful of browsers. This way, it wasn’t as noticeable where the -1px kept one pixel of the background from showing through. Back to the drawing board on this one.


Reply to this email directly or view it on GitHub:
#3694 (comment)

Contributor

scottjehl commented Mar 6, 2012

This is back to bottom: 0; now. Should we close out?

On Mar 6, 2012, at 10:02 PM, Mat Marquis wrote:

Yep, that one’s on me. I was trying to work around the 1px jitter on the fixed footers—we’ve seen it in a handful of browsers. This way, it wasn’t as noticeable where the -1px kept one pixel of the background from showing through. Back to the drawing board on this one.


Reply to this email directly or view it on GitHub:
#3694 (comment)

@agcolom

This comment has been minimized.

Show comment
Hide comment
@agcolom

agcolom Mar 6, 2012

Member

Beautiful!

Member

agcolom commented Mar 6, 2012

Beautiful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment