Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

document size with fixed toolbars #3694

Closed
DGuidi opened this Issue · 9 comments

5 participants

Diego Guidi Henkeh Anne-Gaelle Colom Mat Marquis Scott Jehl
Diego Guidi

This is a page stub with 1.0.1: http://jsfiddle.net/D_Guidi/4NwuG/
the same stub using 1.1.0 RC1: http://jsfiddle.net/D_Guidi/MwYAf/
As you can see, the size of the page is bigger than the viewport.

Henkeh

This issue has already been addressed, see #3663.
Make sure you use the latest versions of jqm as suggested by the template, see here the resulting jsfiddle.
However the issue that the viewport expands one pixel when clicked upon, as suggested here, remains..

Diego Guidi

thanks a lot. I've checked a bit of someone already submitted this issue, but without success.

Anne-Gaelle Colom
Collaborator

I belive this is fixed in latest build (http://jsfiddle.net/agcolom/MwYAf/4/show/) To view the code: http://jsfiddle.net/agcolom/MwYAf/4/

Anne

Diego Guidi

thanks again

Anne-Gaelle Colom
Collaborator

@Wilto I thought this was fixed but now if you look at http://jsfiddle.net/agcolom/MwYAf/4/show/ and click , some scrollbars appear (for about an extra 1pixel)

Anne-Gaelle Colom
Collaborator

The problem comes from

    .ui-footer-fixed {
        bottom: -1px;
        padding-bottom: 1px;
    }

-1px needs to be replaced with 0. Any reason for the -1px?
cc: @Wilto @toddparker @scottjehl @johnbender

Mat Marquis

Yep, that one’s on me. I was trying to work around the 1px jitter on the fixed footers—we’ve seen it in a handful of browsers. This way, it wasn’t as noticeable where the -1px kept one pixel of the background from showing through. Back to the drawing board on this one.

Mat Marquis Wilto closed this issue from a commit
Mat Marquis Wilto Fixes #3694 — `bottom: -1px; padding-bottom: 1px` on fixed footer, pr…
…eviously used to hide 1px “jitter” seen in many browsers during scroll, was triggering scrollbars in some browsers.
f8a4744
Mat Marquis Wilto closed this in f8a4744
Scott Jehl
Anne-Gaelle Colom
Collaborator

Beautiful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.