Skip to content
This repository has been archived by the owner on Oct 8, 2021. It is now read-only.

document size with fixed toolbars #3694

Closed
DGuidi opened this issue Mar 1, 2012 · 9 comments
Closed

document size with fixed toolbars #3694

DGuidi opened this issue Mar 1, 2012 · 9 comments

Comments

@DGuidi
Copy link

DGuidi commented Mar 1, 2012

This is a page stub with 1.0.1: http://jsfiddle.net/D_Guidi/4NwuG/
the same stub using 1.1.0 RC1: http://jsfiddle.net/D_Guidi/MwYAf/
As you can see, the size of the page is bigger than the viewport.

@Henkeh
Copy link

Henkeh commented Mar 1, 2012

This issue has already been addressed, see #3663.
Make sure you use the latest versions of jqm as suggested by the template, see here the resulting jsfiddle.
However the issue that the viewport expands one pixel when clicked upon, as suggested here, remains..

@DGuidi
Copy link
Author

DGuidi commented Mar 1, 2012

thanks a lot. I've checked a bit of someone already submitted this issue, but without success.

@agcolom
Copy link
Contributor

agcolom commented Mar 1, 2012

I belive this is fixed in latest build (http://jsfiddle.net/agcolom/MwYAf/4/show/) To view the code: http://jsfiddle.net/agcolom/MwYAf/4/

Anne

@DGuidi
Copy link
Author

DGuidi commented Mar 2, 2012

thanks again

@agcolom
Copy link
Contributor

agcolom commented Mar 6, 2012

@Wilto I thought this was fixed but now if you look at http://jsfiddle.net/agcolom/MwYAf/4/show/ and click , some scrollbars appear (for about an extra 1pixel)

@agcolom
Copy link
Contributor

agcolom commented Mar 6, 2012

The problem comes from

    .ui-footer-fixed {
        bottom: -1px;
        padding-bottom: 1px;
    }

-1px needs to be replaced with 0. Any reason for the -1px?
cc: @Wilto @toddparker @scottjehl @johnbender

@Wilto
Copy link
Contributor

Wilto commented Mar 6, 2012

Yep, that one’s on me. I was trying to work around the 1px jitter on the fixed footers—we’ve seen it in a handful of browsers. This way, it wasn’t as noticeable where the -1px kept one pixel of the background from showing through. Back to the drawing board on this one.

@Wilto Wilto closed this as completed in f8a4744 Mar 6, 2012
@scottjehl
Copy link

This is back to bottom: 0; now. Should we close out?

On Mar 6, 2012, at 10:02 PM, Mat Marquis wrote:

Yep, that one’s on me. I was trying to work around the 1px jitter on the fixed footers—we’ve seen it in a handful of browsers. This way, it wasn’t as noticeable where the -1px kept one pixel of the background from showing through. Back to the drawing board on this one.


Reply to this email directly or view it on GitHub:
#3694 (comment)

@agcolom
Copy link
Contributor

agcolom commented Mar 6, 2012

Beautiful!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants