Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

$.mobile.listview.prototype.options.inset = true; does not work for data-filter=true #3761

Closed
marceloverdijk opened this Issue · 13 comments

5 participants

@marceloverdijk

I'm using $.mobile.listview.prototype.options.inset = true; to change all my lists to inset so avoiding to put everywhere data-inset="true".

However when adding data-filter="true" to a list view then the list is inset, but the filter field is not.

1) is there another 'global' option I have to set to get the listview filter field to be inset?
2) is there a page describing all config options?

@johnbender johnbender closed this in 748ada1
@jakeboone02

@marceloverdijk - There is a comprehensive page for the data-* attributes, and a page for the global configuration options, but no single page for the plugin-specific options (that I know of, at least). For those you have to visit the individual docs pages for each plugin, like this one for listviews.

@toddparker - Might be useful to have a page that summarizes all the plugin prototype options.

@toddparker

@jakeboone02 - are you suggesting a page that just pulls all the options together across all widgets? If we did that, I'd want to not duplicate content so we'd need to use includes or ajax in the guts of each page or something like that. Or we could just have a page that deep links to the options/methods/events for every plugin for quick reference. Want to sketch out what you had in mind?

@jakeboone02

@toddparker - Actually, I was looking at the lists overview page and thinking there wasn't a place where all the options were listed. That's only true for that plugin...I forgot that all the others had their own options/methods/events pages. So maybe what I'm thinking is just to make those pages for the listview plugin.

@toddparker

Good point, We should create the basics | options | methods | events nav and pages for lists. That list overview page can be the basics "tab". If you want to take a crack at creating these 3 pages, we can try to get these in for 1.1.

@jakeboone02

Sure, I'll give it a shot.

@marceloverdijk

The issue is closed now, but the 1st question / issue is not yet answered:

I'm using $.mobile.listview.prototype.options.inset = true; to change all my lists to inset so avoiding to put everywhere data-inset="true".

However when adding data-filter="true" to a list view then the list is inset, but the filter field is not.

1) is there another 'global' option I have to set to get the listview filter field to be inset?

@marceloverdijk

Can you reopen this issue?

@toddparker

@marceloverdijk - So when you set the inset global option, then add the filter attribute on a list it looks different than this?
http://jquerymobile.com/test/docs/lists/lists-search-inset.html

A test page using jsbin would be helpful to confirm this. Template: http://jsbin.com/otojuv/edit

@johnbender

@marceloverdijk

You should be able to use the prototype option now and it will work for the filter field too.

@marceloverdijk

@johnbender you mean this has been fixed, so need to provide example using jsbin as suggested by @toddparker ?

@toddparker

This should now be fixed, but if you want to add a test page using latest with the code you had in mind, we can confirm.

@marceloverdijk

Yes, this now works as expected: http://jsbin.com/otojuv/4/edit
Nice to have this, saves me from adding data-inset="true" everywhere :-)

@dotnetwise

It works, but the search box is not part of the list. Can it be easily added?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.