data-overlay-theme bug in 1.1 rc1 #3779

toddparker opened this Issue Mar 9, 2012 · 3 comments


None yet

2 participants


If you set the overlay theme on a page, that theme swatch will then continue to override all subsequent dialog overlays until you refresh. To reproduce, go here:

  1. Click on the "custom overlay swatch" button near the bottom. This dialog has swatch "e" set for the overlay.
  2. Close the dialog, then open any other dialog on this page - the overlay swatch will remain E instead of using the default A swatch

This will also carry over onto other pages. If you navigate to the transitions page, all the dialogs there will have an E swatch.

@scottjehl scottjehl was assigned Mar 9, 2012

It's all yours!

@scottjehl scottjehl pushed a commit that closed this issue Mar 9, 2012
scottjehl parent is actually what we're looking for here, given that getInherit…
…edTheme mimics the closest() method. Fixes #3779
@scottjehl scottjehl closed this in 054b9a4 Mar 9, 2012

That one was tricky. Think we're good now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment