New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-overlay-theme bug in 1.1 rc1 #3779

Closed
toddparker opened this Issue Mar 9, 2012 · 3 comments

Comments

Projects
None yet
2 participants
@toddparker
Contributor

toddparker commented Mar 9, 2012

If you set the overlay theme on a page, that theme swatch will then continue to override all subsequent dialog overlays until you refresh. To reproduce, go here:
http://jquerymobile.com/test/docs/pages/page-dialogs.html

  1. Click on the "custom overlay swatch" button near the bottom. This dialog has swatch "e" set for the overlay.
  2. Close the dialog, then open any other dialog on this page - the overlay swatch will remain E instead of using the default A swatch

This will also carry over onto other pages. If you navigate to the transitions page, all the dialogs there will have an E swatch.

@ghost ghost assigned scottjehl Mar 9, 2012

@scottjehl

This comment has been minimized.

Show comment
Hide comment
@scottjehl

scottjehl Mar 9, 2012

Contributor

I should take this one.

On Fri, Mar 9, 2012 at 8:43 AM, Todd Parker <
reply@reply.github.com

wrote:

If you set the overlay theme on a page, that theme swatch will then
continue to override all subsequent dialog overlays until you refresh. To
reproduce, go here:
http://jquerymobile.com/test/docs/pages/page-dialogs.html

  1. Click on the "custom overlay swatch" button near the bottom. This
    dialog has swatch "e" set for the overlay.
  2. Close the dialog, then open any other dialog on this page - the overlay
    swatch will remain E instead of using the default A swatch

This will also carry over onto other pages. If you navigate to the
transitions page, all the dialogs there will have an E swatch.


Reply to this email directly or view it on GitHub:
#3779

Contributor

scottjehl commented Mar 9, 2012

I should take this one.

On Fri, Mar 9, 2012 at 8:43 AM, Todd Parker <
reply@reply.github.com

wrote:

If you set the overlay theme on a page, that theme swatch will then
continue to override all subsequent dialog overlays until you refresh. To
reproduce, go here:
http://jquerymobile.com/test/docs/pages/page-dialogs.html

  1. Click on the "custom overlay swatch" button near the bottom. This
    dialog has swatch "e" set for the overlay.
  2. Close the dialog, then open any other dialog on this page - the overlay
    swatch will remain E instead of using the default A swatch

This will also carry over onto other pages. If you navigate to the
transitions page, all the dialogs there will have an E swatch.


Reply to this email directly or view it on GitHub:
#3779

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Mar 9, 2012

Contributor

It's all yours!

Contributor

toddparker commented Mar 9, 2012

It's all yours!

@scottjehl scottjehl closed this in 054b9a4 Mar 9, 2012

@scottjehl

This comment has been minimized.

Show comment
Hide comment
@scottjehl

scottjehl Mar 9, 2012

Contributor

That one was tricky. Think we're good now...

Contributor

scottjehl commented Mar 9, 2012

That one was tricky. Think we're good now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment