off('tap') doesn't remove mousedown and vmousedown events #3790

Closed
intval opened this Issue Mar 11, 2012 · 5 comments

4 participants

@intval

In that cases constructions like elem.off('tap').on('tap') makes the callback fire up twice on PC.

@johnbender

@intval

This will require the addition of a remove callback to the special tap event, which (imo) isn't a priority for the 1.1 release.

https://github.com/jquery/jquery-mobile/blob/master/js/jquery.mobile.event.js#L73

If you're feeling adventurous you can use @cowboy's guide to special events and submit a pull request:

http://benalman.com/news/2010/03/jquery-special-events/

That would speed things along :D. Thanks for submitting the issue.

@jesperveldhuizen

Any updates on this? It's quite annoying that it's not possible to 'off' a 'tap' event.

@arschmitz
jQuery Foundation member

this is on our list of priorities for 1.4

@jesperveldhuizen

I have modified the tap event to support the 'off' function. I'm not sure if this is 100% the way to go with the events (first time I've been playing around with this). It works for me though.

You can see the code here: http://jsfiddle.net/w8KJv/ (I don't know how the pull request system works...)

@arschmitz
jQuery Foundation member

this is fixed by commit 3ba4a42

@arschmitz arschmitz closed this May 8, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment