Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

transitions.js shouldn't be a dependency of nav.js #3807

Closed
scottjehl opened this Issue · 4 comments

3 participants

@scottjehl

Just wanted a second opinion on this, but I'm pretty sure transitions.js should not be listed as a dependency in navigation.js. Navigation comes with its own "none" transition handler, which uses the nav model without any CSS transitions.

@johnbender @gseguin - thoughts?

@gseguin gseguin was assigned
@johnbender

I think that's the only reason for that dep, but I'll double check.

@gseguin
Collaborator

https://github.com/jquery/jquery-mobile/blob/master/js/jquery.mobile.navigation.js#L492 will cause an exception if we don't require transition.js

@scottjehl
@scottjehl

Closing out. I forgot the none handler is baked into the default transition handler

@scottjehl scottjehl closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.