Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

transitions.js shouldn't be a dependency of nav.js #3807

Closed
scottjehl opened this Issue Mar 13, 2012 · 4 comments

Comments

Projects
None yet
3 participants
Contributor

scottjehl commented Mar 13, 2012

Just wanted a second opinion on this, but I'm pretty sure transitions.js should not be listed as a dependency in navigation.js. Navigation comes with its own "none" transition handler, which uses the nav model without any CSS transitions.

@johnbender @gseguin - thoughts?

@ghost ghost assigned gseguin Mar 13, 2012

Contributor

johnbender commented Mar 13, 2012

I think that's the only reason for that dep, but I'll double check.

Member

gseguin commented Mar 13, 2012

https://github.com/jquery/jquery-mobile/blob/master/js/jquery.mobile.navigation.js#L492 will cause an exception if we don't require transition.js

Contributor

scottjehl commented Mar 13, 2012

ah ya?

Maybe these lines should start out in nav js then? Before being redefined by the outInHandler

https://github.com/jquery/jquery-mobile/blob/master/js/jquery.mobile.transition.js#80

On Mar 13, 2012, at 11:14 PM, Ghislain Seguin wrote:

https://github.com/jquery/jquery-mobile/blob/master/js/jquery.mobile.navigation.js#L492 will cause an exception if we don't require transition.js


Reply to this email directly or view it on GitHub:
#3807 (comment)

Contributor

scottjehl commented Mar 14, 2012

Closing out. I forgot the none handler is baked into the default transition handler

@scottjehl scottjehl closed this Mar 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment