vclick events don't have pageX/pageY defined on them #3815

Closed
jblas opened this Issue Mar 14, 2012 · 1 comment

Comments

Projects
None yet
1 participant
@jblas
Contributor

jblas commented Mar 14, 2012

vclick events don't have pageX/pageY defined on them. This seems to be a regression due to some changes made for jQuery 1.7.1 support.

In createVirtualEvent() (jquery.mobile.vmouse.js) there is a line that looks like this:

if ( t.search(/mouse/) >-1 ) {
    props = mouseEventProps;
}

it should be:

if ( t.search(/^(mouse|click)/) >-1 ) {
    props = mouseEventProps;
}

otherwise no mouse props are copied off the original event.

This problem was originally reported by @jzaefferer.

jblas added a commit that referenced this issue Mar 14, 2012

Fix for issue #3815 - vclick events don't have pageX/pageY defined on…
… them

- Modified createVirtualEvent() so that it uses the mouseHook properties if the original event type starts with "mouse" or "click". The original regex was only looking for "mouse".

@ghost ghost assigned jblas Mar 14, 2012

@jblas

This comment has been minimized.

Show comment
Hide comment
@jblas

jblas Mar 14, 2012

Contributor

Fix landed on MASTER.

@toddparker @johnbender

Can we make sure that this makes it into 1.1?

Contributor

jblas commented Mar 14, 2012

Fix landed on MASTER.

@toddparker @johnbender

Can we make sure that this makes it into 1.1?

@jblas jblas closed this Mar 14, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment