Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

1.1rc1 Button text now truncated with ellipsis that didn't used to be #3826

Closed
cnickchen opened this Issue Mar 15, 2012 · 13 comments

Comments

Projects
None yet
8 participants

Same issue on iphone 5, 4 and android 2.3 in portrait mode. Okay in landscape mode. Fine on ipad 2 but screen is bigger!

I have 4 buttons displayed. The second and 4th buttons now have text being truncated with ellipsis.

Here is the real example footer.....

@Wilto Wilto was assigned Mar 15, 2012

+1

Contributor

Wilto commented Mar 19, 2012

At what point did this behavior seem to change? I checked as far back as 1.0 proper, and button text seemed to truncate in the same way. Could one of you submit a reduced test case using the template at http://jsbin.com/omacox/edit, illustrating the exact nature of this issue?

It's not that one truncated and one didn't truncate it's that the space for
text seems smaller and truncates where it hasn't in the past. Create a
footer with three buttons see how many characters you can fit in 1.0.1 as
opposed to 1.1 RC1

Sincerely

Justin Sunseri
Please don't print this e-mail unless you really need to.

On Mon, Mar 19, 2012 at 10:57 AM, Mat Marquis <
reply@reply.github.com

wrote:

It doesnt seem as though this is behavior has changed At what point did
this behavior seem to change? I checked as far back as 1.0 proper, and
button text seemed to truncate in the same way. Could one of you submit a
reduced test case using the template at http://jsbin.com/omacox/edit,
illustrating the exact nature of this issue?


Reply to this email directly or view it on GitHub:
#3826 (comment)

Thinking this is related to Issue #3805. There is a discussion - and probable solution - there re: ellipsis in the nav bar.

sasacoh commented Mar 19, 2012

Try to reduce padding (jquery.mobile.structure-1.1.0-rc.1.min.css)
.ui-header .ui-btn-inner,.ui-footer .ui-btn-inner,.ui-mini .ui-btn-inner {
font-size: 13px;
padding: .55em 1.5em .5em /* padding: .55em 8px .5em - this works for me (on iphone, android) */
}

Changed in this commit: a92e2c8

I don't know if it is related. But I had a problem with collapsible set using tag for the heading. On Chrome it renders fine but with Firefox and IE it was causing elipsis and had to put this:

.ui-collapsible-heading span {
display: block;
}

because using a heading tag h1-6 was causing me problems with the way i've customized the collapsible set.

Member

agcolom commented Mar 19, 2012

@Wilto I wonder if this is related to something that happened to #3798. When I checked and produced the jsfiddle then, there was no ellipsis and the text was going under the long bubble, but now there is an ellipsis (fixing the issue #3798). I wonder whether the fix applied is causing this new current issue.

Hope this helps :-)

Here is the real example footer.....

Contributor

Wilto commented Apr 2, 2012

This should be patched up following a handful of tweaks late last week and over the weekend—have a look now and let me know if anything is still looking off.

Thanks, guys!

Will do.

thanks

From:
Mat Marquis
reply@reply.github.com
To:
cnickchen cnickchen@newpenn.com
Date:
04/02/2012 01:10 PM
Subject:
Re: [jquery-mobile] 1.1rc1 Button text now truncated with ellipsis that
didn't used to be (#3826)

This should be patched up following a handful of tweaks late last week and
over the weekend?have a look now and let me know if anything is still
looking off.

Thanks, guys!


Reply to this email directly or view it on GitHub:
#3826 (comment)

Download mobile git copy from http://code.jquery.com/ ? Thanks

From:
Mat Marquis
reply@reply.github.com
To:
cnickchen cnickchen@newpenn.com
Date:
04/02/2012 01:10 PM
Subject:
Re: [jquery-mobile] 1.1rc1 Button text now truncated with ellipsis that
didn't used to be (#3826)

This should be patched up following a handful of tweaks late last week and
over the weekend?have a look now and let me know if anything is still
looking off.

Thanks, guys!


Reply to this email directly or view it on GitHub:
#3826 (comment)

Tested using latest and now it looks good -- fixed. thanks

From:
Mat Marquis
reply@reply.github.com
To:
cnickchen cnickchen@newpenn.com
Date:
04/02/2012 01:10 PM
Subject:
Re: [jquery-mobile] 1.1rc1 Button text now truncated with ellipsis that
didn't used to be (#3826)

This should be patched up following a handful of tweaks late last week and
over the weekend?have a look now and let me know if anything is still
looking off.

Thanks, guys!


Reply to this email directly or view it on GitHub:
#3826 (comment)

Contributor

toddparker commented Apr 5, 2012

Closing as fixed.

@toddparker toddparker closed this Apr 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment