Skip to content

Something wrong with buttons in footer in latest #3898

Closed
agcolom opened this Issue Mar 23, 2012 · 5 comments

4 participants

@agcolom
jQuery Foundation member
agcolom commented Mar 23, 2012

If you look at http://jquerymobile.com/test/docs/toolbars/docs-footers.html
there is something wrong with the way the buttons now appear in the footer:
button one top left corner, button two top right corner, then center and sligthly on top of button one and two but under their labels...

@agcolom
jQuery Foundation member
agcolom commented Mar 23, 2012

Note that this does not happen with 1.1RC1 or 1.0.1, but each version has its own rendering:
http://jquerymobile.com/demos/1.1.0-rc.1/docs/toolbars/docs-footers.html
http://jquerymobile.com/demos/1.0.1/docs/toolbars/docs-footers.html

1.0.1 is as I would expect (four buttons fitting the text size, one after the other)
in 1.1RC1 the first 2 buttons are small (normal size), and the next two are below the first two and take full width of the footer

@toddparker

Good catch. This does look like a regression. Seems that a standard button (or link button) in the footer should be both mini and inline by default to re-create the 1.0 behavior. This looks like the first and last are somehow being treated like header buttons in the left and right slots and the other two are standard, block-level buttons.

@Wilto Wilto was assigned Mar 24, 2012
@scottjehl

I'm not sure it'd need to be mini to replicate 1.0, just inline right? Mini is new after 1.0 isn't it?

@toddparker

Looking at the default toolbar behavior in 1.0.1, it appears that a link button in a footer is both "mini" styled and inline:
http://jquerymobile.com/demos/1.0.1/docs/toolbars/docs-footers.html

@scottjehl

ah right 1.0.1 that change went in? cool. carry on!

@Wilto Wilto added a commit that closed this issue Mar 28, 2012
@Wilto Wilto Fixes #3898 - Header/footer mini button styles cleaned up. Footer but…
…tons are no longer subject to the same left/right button logic as headers. Default mini/inline styles can now be overridden by setting either attribute to “false”.
bbe901d
@Wilto Wilto closed this in bbe901d Mar 28, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.