Something wrong with buttons in footer in latest #3898

Closed
agcolom opened this Issue Mar 23, 2012 · 5 comments

Comments

Projects
None yet
4 participants
@agcolom
Member

agcolom commented Mar 23, 2012

If you look at http://jquerymobile.com/test/docs/toolbars/docs-footers.html
there is something wrong with the way the buttons now appear in the footer:
button one top left corner, button two top right corner, then center and sligthly on top of button one and two but under their labels...

@agcolom

This comment has been minimized.

Show comment
Hide comment
@agcolom

agcolom Mar 23, 2012

Member

Note that this does not happen with 1.1RC1 or 1.0.1, but each version has its own rendering:
http://jquerymobile.com/demos/1.1.0-rc.1/docs/toolbars/docs-footers.html
http://jquerymobile.com/demos/1.0.1/docs/toolbars/docs-footers.html

1.0.1 is as I would expect (four buttons fitting the text size, one after the other)
in 1.1RC1 the first 2 buttons are small (normal size), and the next two are below the first two and take full width of the footer

Member

agcolom commented Mar 23, 2012

Note that this does not happen with 1.1RC1 or 1.0.1, but each version has its own rendering:
http://jquerymobile.com/demos/1.1.0-rc.1/docs/toolbars/docs-footers.html
http://jquerymobile.com/demos/1.0.1/docs/toolbars/docs-footers.html

1.0.1 is as I would expect (four buttons fitting the text size, one after the other)
in 1.1RC1 the first 2 buttons are small (normal size), and the next two are below the first two and take full width of the footer

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Mar 24, 2012

Contributor

Good catch. This does look like a regression. Seems that a standard button (or link button) in the footer should be both mini and inline by default to re-create the 1.0 behavior. This looks like the first and last are somehow being treated like header buttons in the left and right slots and the other two are standard, block-level buttons.

Contributor

toddparker commented Mar 24, 2012

Good catch. This does look like a regression. Seems that a standard button (or link button) in the footer should be both mini and inline by default to re-create the 1.0 behavior. This looks like the first and last are somehow being treated like header buttons in the left and right slots and the other two are standard, block-level buttons.

@ghost ghost assigned Wilto Mar 24, 2012

@scottjehl

This comment has been minimized.

Show comment
Hide comment
@scottjehl

scottjehl Mar 26, 2012

Contributor

I'm not sure it'd need to be mini to replicate 1.0, just inline right? Mini is new after 1.0 isn't it?

Contributor

scottjehl commented Mar 26, 2012

I'm not sure it'd need to be mini to replicate 1.0, just inline right? Mini is new after 1.0 isn't it?

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Mar 26, 2012

Contributor

Looking at the default toolbar behavior in 1.0.1, it appears that a link button in a footer is both "mini" styled and inline:
http://jquerymobile.com/demos/1.0.1/docs/toolbars/docs-footers.html

Contributor

toddparker commented Mar 26, 2012

Looking at the default toolbar behavior in 1.0.1, it appears that a link button in a footer is both "mini" styled and inline:
http://jquerymobile.com/demos/1.0.1/docs/toolbars/docs-footers.html

@scottjehl

This comment has been minimized.

Show comment
Hide comment
@scottjehl

scottjehl Mar 26, 2012

Contributor

ah right 1.0.1 that change went in? cool. carry on!

Contributor

scottjehl commented Mar 26, 2012

ah right 1.0.1 that change went in? cool. carry on!

@Wilto Wilto closed this in bbe901d Mar 28, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment