New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Count Bubble position problem #3979

Closed
Azuo opened this Issue Apr 6, 2012 · 6 comments

Comments

Projects
None yet
5 participants
@Azuo
Contributor

Azuo commented Apr 6, 2012

count bubble position using 1.1.0.rc1:
http://jsfiddle.net/7N6Yh/
Everything is OK.

count bubble position using 1.1.0.rc2:
http://jsfiddle.net/7N6Yh/2/
Count bubble overlaps the text in a custom multi-select menu, and is placed too close to the split button in a listview.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Apr 6, 2012

Contributor

We should touch this up before final. Thanks.

Contributor

toddparker commented Apr 6, 2012

We should touch this up before final. Thanks.

@ghost ghost assigned Wilto Apr 6, 2012

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Apr 11, 2012

Member

@Wilto

Are you or somebody else already working on this? If you like I can create a pull request that fixes those issues. Just let me know.

Member

jaspermdegroot commented Apr 11, 2012

@Wilto

Are you or somebody else already working on this? If you like I can create a pull request that fixes those issues. Just let me know.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Apr 11, 2012

Contributor

I don't believe @Wilto has worked on this yet so if you want to work on a pull request, we'd be happy to give it a look.

Contributor

toddparker commented Apr 11, 2012

I don't believe @Wilto has worked on this yet so if you want to work on a pull request, we'd be happy to give it a look.

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Apr 11, 2012

Contributor

BTW - we've decided to freeze the code and get final out sooner so this will end up landing in the first maintenance release.

Contributor

toddparker commented Apr 11, 2012

BTW - we've decided to freeze the code and get final out sooner so this will end up landing in the first maintenance release.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Apr 12, 2012

Member

Azuo used a listview with data-mini="true" in his example. That is not supported (yet) as far as I know.
In my pull request I only enclosed two minor changes that make sure there is no overflow in case of a mini button in listview. So they will look good but for consistency the padding/position should be tweaked. I thought it was better to wait with adding those rules until mini listviews are going to be supported.

Edit: I replaced my original PR's by a new one which also makes listviews compatible with data-mini="true"

Member

jaspermdegroot commented Apr 12, 2012

Azuo used a listview with data-mini="true" in his example. That is not supported (yet) as far as I know.
In my pull request I only enclosed two minor changes that make sure there is no overflow in case of a mini button in listview. So they will look good but for consistency the padding/position should be tweaked. I thought it was better to wait with adding those rules until mini listviews are going to be supported.

Edit: I replaced my original PR's by a new one which also makes listviews compatible with data-mini="true"

@atuttle

This comment has been minimized.

Show comment
Hide comment
@atuttle

atuttle Apr 18, 2012

I've also noticed that the count bubble is not repositioned in this case (link icon disabled):

<li data-icon="false"><a>Whatever <span class="ui-li-count">55</span></a></li>

I made this change in a custom css file I'm using for my application and it's working well for me, but it's not tested against all possible cases:

li[data-icon=false] .ui-li-count {
    right: 30px;
}

atuttle commented Apr 18, 2012

I've also noticed that the count bubble is not repositioned in this case (link icon disabled):

<li data-icon="false"><a>Whatever <span class="ui-li-count">55</span></a></li>

I made this change in a custom css file I'm using for my application and it's working well for me, but it's not tested against all possible cases:

li[data-icon=false] .ui-li-count {
    right: 30px;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment