New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sliders label ID gets overwritten #3981

Closed
MauriceG opened this Issue Apr 7, 2012 · 2 comments

Comments

Projects
None yet
3 participants
@MauriceG
Contributor

MauriceG commented Apr 7, 2012

A small issue: If a slider's label has an ID, it is overwritten with the sliders ID concatenated with "-label" (ine 39 in jquery.mobile.forms.slider.js)
I was stumbling about that, when trying to change the labels of sliders dynamical.
May a hint in the docs were also ok.

Demo at:
http://jsfiddle.net/MauriceG/jn2Y6/

@ghost ghost assigned jasondscott May 24, 2012

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker May 24, 2012

Contributor

@jasondscott - mind reviewing this?

Contributor

toddparker commented May 24, 2012

@jasondscott - mind reviewing this?

@MauriceG

This comment has been minimized.

Show comment
Hide comment
@MauriceG

MauriceG May 25, 2012

Contributor

fixed due to merged PR #4433
thanks @jasondscott and @johnbender !

Contributor

MauriceG commented May 25, 2012

fixed due to merged PR #4433
thanks @jasondscott and @johnbender !

@MauriceG MauriceG closed this May 25, 2012

jasondscott added a commit that referenced this issue May 25, 2012

Merge pull request #4449 from jasondscott/3981_SliderIdTests
Added tests for #3981 - Slider label ID gets overwritten

jasondscott added a commit that referenced this issue May 29, 2012

Merge pull request #4449 from jasondscott/3981_SliderIdTests
Added tests for #3981 - Slider label ID gets overwritten
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment