Skip to content

Sliders label ID gets overwritten #3981

Closed
MauriceG opened this Issue Apr 7, 2012 · 2 comments

3 participants

@MauriceG
MauriceG commented Apr 7, 2012

A small issue: If a slider's label has an ID, it is overwritten with the sliders ID concatenated with "-label" (ine 39 in jquery.mobile.forms.slider.js)
I was stumbling about that, when trying to change the labels of sliders dynamical.
May a hint in the docs were also ok.

Demo at:
http://jsfiddle.net/MauriceG/jn2Y6/

@MauriceG MauriceG added a commit to MauriceG/jquery-mobile that referenced this issue Apr 16, 2012
@MauriceG MauriceG Suggestion for #3981 - use existing label-id if there, otherwise gene…
…rate ID from sliders ID
473ae28
@jasondscott jasondscott was assigned May 24, 2012
@toddparker

@jasondscott - mind reviewing this?

@jasondscott jasondscott pushed a commit to jasondscott/jquery-mobile that referenced this issue May 25, 2012
Jason Scott Added tests for #3981 - Slider label ID gets overwritten
Tests for Issue #3981 and PR #4433
8c7d3e9
@MauriceG

fixed due to merged PR #4433
thanks @jasondscott and @johnbender !

@MauriceG MauriceG closed this May 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.