Create TransitionHandler object and expose it as an API #4022

Closed
johnbender opened this Issue Apr 12, 2012 · 6 comments

Comments

Projects
None yet
4 participants
Contributor

johnbender commented Apr 12, 2012

Recently we created two alternate transition handlers that encapsulate the sequential transition behavior and parallel transition behavior. Being that both are complex but relatively small this presents a really nice opportunity to refactor and provide an object api for advanced users to extend.

https://gist.github.com/df62ba1902a7569e11fe

The above link is a 10 minute untested refactor example.

johnbender was assigned Apr 12, 2012

Contributor

ldeluca commented Oct 24, 2014

@johnbender I haven't seen any activity on this issue in over 2 years. We're in the process of cleaning up old issues. Can you confirm whether or not this is still an issue with the latest jQM?

Owner

arschmitz commented Oct 24, 2014

@ldeluca this is very much something still on the road map its part of the nav work that is on going. But there really has not been any update since this sadly

gabrielschulhof added this to the 1.5.0 milestone Jan 15, 2015

Contributor

gabrielschulhof commented Jan 15, 2015

I believe this is solved. You can now use transitions on their own: http://jsbin.com/zexic/1/ The styling is not exactly kosher, but the point is that it works. @arschmitz can we set up a checklist as to what else needs to be done to consider this feature production quality?

Contributor

gabrielschulhof commented Jan 15, 2015

I guess maybe a demo ... ?

Contributor

gabrielschulhof commented Jan 15, 2015

Desired outcomes:

  • 1. pagecontainer does not AMD-depend on transitions and implements switching to another page via a simple hide-old/show-new
    • 1. Create pagecontainer extension that AMD-depends on transitions (maybe use transition() as the extension point) and implements switching to another page via transitions. This should allow us to later drop in JS-based transitions
  • 2. transitions do not AMD-depend on pagecontainer
Contributor

gabrielschulhof commented Jan 18, 2015

@arschmitz in order to achieve objective 2. I need to move $.mobile.focusPage out of js/navigation.js. What do you think would be a good place for it? I was thinking about the page widget, but I don't like that the function searches for the page title, because that makes assumptions about the page's structure. This functionality was added way back in edaa43c: "[...]Improves a11y experience."

I'm in the process of writing a PR for this issue, and for now I've moved the function into helpers. helpers is needed by both widgets/pagecontainer.js and transitions/transition.js - but, of course, so is widgets/page :)

Relevant issues:
#1342
#2965

@gabrielschulhof gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Jan 19, 2015

@gabrielschulhof gabrielschulhof Pagecontainer: Factor transition handling into an extension 9545070

@gabrielschulhof gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Jan 19, 2015

@gabrielschulhof gabrielschulhof Navigation: Move $.mobile.focusPage() into helpers
This allows transitions to live without navigation

Fixes gh-4022
099fca2

@gabrielschulhof gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Jan 20, 2015

@gabrielschulhof gabrielschulhof Navigation: Move $.mobile.focusPage() into helpers
This allows transitions to live without navigation

Fixes gh-4022
Fixes gh-7158
aa7226a

@gabrielschulhof gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Jan 22, 2015

@gabrielschulhof gabrielschulhof Pagecontainer: Factor transition handling into an extension 05da9c6

@gabrielschulhof gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Jan 22, 2015

@gabrielschulhof gabrielschulhof Navigation: Move $.mobile.focusPage() into helpers
This allows transitions to live without navigation

Fixes gh-4022
Fixes gh-7158
387a921

@gabrielschulhof gabrielschulhof added a commit to gabrielschulhof/jquery-mobile that referenced this issue Jan 28, 2015

@gabrielschulhof gabrielschulhof Navigation: Move $.mobile.focusPage() into helpers
This allows transitions to live without navigation

Fixes gh-6929
Fixes gh-4022
Fixes gh-7158
fc37afb

@kapilgarg1996 kapilgarg1996 added a commit to kapilgarg1996/jquery-mobile that referenced this issue Jun 27, 2015

@gabrielschulhof @kapilgarg1996 gabrielschulhof + kapilgarg1996 Navigation: Separate pagecontainer and transitions
Fixes gh-6929
Fixes gh-4022
Fixes gh-7158
Closes gh-7930
bc22155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment