New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Listview data-mini="true" should be ignored #4114

Closed
jaspermdegroot opened this Issue Apr 19, 2012 · 3 comments

Comments

Projects
None yet
3 participants
@jaspermdegroot
Member

jaspermdegroot commented Apr 19, 2012

From a JS point of view data-mini true on listviews is supported. The ul gets class ui-mini. The CSS is not ready for it though. A basic link list will look fine, but as soon as thumbs, count bubbles, icons, split buttons, etc. are involved there are many positioning issues. List dividers and static li's have there own font-size, but no adjustment for when used in mini listview.

The documentation about listviews and the data- attribute reference doesn't say anything about mini on listviews being supported. Still I noticed while reading issues here, many people think it is a supported option.

Is it in the planning to update the CSS to support this? If not or in the meantime, shouldn't the JS ignore the data-mini="true" when it is used for an ul with data-role listview?

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker Apr 28, 2012

Contributor

We don't support mini listviews and I'm not sure it's a good idea from a usability perspective. I agree that we should probably just ignore this data attriburt on listviews and not add the class because we haven't worked on supporting that and I can see a lot of things breaking.

Contributor

toddparker commented Apr 28, 2012

We don't support mini listviews and I'm not sure it's a good idea from a usability perspective. I agree that we should probably just ignore this data attriburt on listviews and not add the class because we haven't worked on supporting that and I can see a lot of things breaking.

@ghost ghost assigned jaspermdegroot May 28, 2012

jaspermdegroot added a commit that referenced this issue May 28, 2012

Merge pull request #4464 from uGoMobi/issue_#4114
Fixes issue #4114 - mini listview not supported
@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot May 28, 2012

Member

Close as fixed by removing the option from the JS.

Member

jaspermdegroot commented May 28, 2012

Close as fixed by removing the option from the JS.

@cmfcmf

This comment has been minimized.

Show comment
Hide comment
@cmfcmf

cmfcmf Oct 10, 2013

Could you please add a notice to the docu explicitly saying that data-mini is ignored on listviews?

cmfcmf commented Oct 10, 2013

Could you please add a notice to the docu explicitly saying that data-mini is ignored on listviews?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment