Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Listview - only use 'lastval' functionality with default filter behaviour #4133
The listview tracks the last value ('lastval') entered by the user when filtering items in a listview.
I suggest that this functionality should only be enabled when the default filtering callback is in use. Otherwise, it should check all items on each filter.
The reason is, is that if I've implemented a custom filtering callback, it may not be valid to only check un-hidden items on filter text changes that increase the length of the filter.
My scenario is that I'm using the data-filter attribute on items that contains formatted data and I want users to be able to separate multiple filters for the same list with commas eg. "me,you,her,him". Once the user types "me", only the "me" items are filterable since all the "you" items etc are hidden.
I plan to add a code mod to suggest this but wanted to raise the issue in case I don't get around to it (or accepted!) :)