New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed header overrides page #4176

Closed
DGuidi opened this Issue Apr 23, 2012 · 5 comments

Comments

Projects
None yet
5 participants
@DGuidi

DGuidi commented Apr 23, 2012

I've build a fiddle of a "bug" that I'm experiencing: http://jsfiddle.net/y4AXb/4/

When a fixed header (bigger than the usual) is used with a data-id, the page is rendered with errors.
I've resolved the issue simply calling $.mobile.activePage.trigger('updatelayout') after page rendering.

@MauriceG

This comment has been minimized.

Show comment
Hide comment
@MauriceG

MauriceG Apr 23, 2012

Contributor

I can confirm this issue when using "oversized" headers as persistent toolbars.
But only, if the second page is shown the first time.

May this is caused by the changed markup order when using persistent toolbars.
At those pages, after the first navigation, the header-markup is appendedTo the content-markup
and it seems the header then could not find its closest ui-page to compute and give the page container the needed top-padding.

Contributor

MauriceG commented Apr 23, 2012

I can confirm this issue when using "oversized" headers as persistent toolbars.
But only, if the second page is shown the first time.

May this is caused by the changed markup order when using persistent toolbars.
At those pages, after the first navigation, the header-markup is appendedTo the content-markup
and it seems the header then could not find its closest ui-page to compute and give the page container the needed top-padding.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Apr 23, 2012

Member

After reading @MauriceG his comment I figured the cause of the issue is most probably same as #4019
When you inspect the code of the fiddle you'll see that the content comes before the header in the html.

Member

jaspermdegroot commented Apr 23, 2012

After reading @MauriceG his comment I figured the cause of the issue is most probably same as #4019
When you inspect the code of the fiddle you'll see that the content comes before the header in the html.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Jun 14, 2012

Member

I tested the fiddle from @DGuidi with the changes from PR #4260 and it does fix the issue.

Member

jaspermdegroot commented Jun 14, 2012

I tested the fiddle from @DGuidi with the changes from PR #4260 and it does fix the issue.

@DGuidi

This comment has been minimized.

Show comment
Hide comment
@DGuidi

DGuidi Jun 15, 2012

thanks a lot :)

DGuidi commented Jun 15, 2012

thanks a lot :)

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Jun 15, 2012

Member

Fixed by commit 0992512.

Member

jaspermdegroot commented Jun 15, 2012

Fixed by commit 0992512.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment