Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Regression issue with multiple selects #4233

Closed
agcolom opened this Issue · 7 comments

3 participants

@agcolom
Collaborator

Since 1.1.0, the text will go over the bubble on multiple selects:
http://jsfiddle.net/agcolom/4PX9x/18/show/ (latest)
http://jsfiddle.net/agcolom/4PX9x/19/show/ (1.1.0)

while it was cutting off nicely before:
http://jsfiddle.net/agcolom/4PX9x/20/show/ (1.0.1)

I think the padding right (here 45px) needs increasing since the bubble position has been modified.

@MauriceG MauriceG referenced this issue from a commit in MauriceG/jquery-mobile
@MauriceG MauriceG Fix for #4233 - Multiple selected values in multi select goes over bu…
…bble
73c458e
@MauriceG

Hi Anne :-)
I've supplied PR #4235 for this issue.
Do you think 65px are enough?
May it looks a bit scarce?
Maurice

@agcolom
Collaborator
@MauriceG

yes, but in the unlikely case if more than 9 selected values,
the title again goes over the bubble.
Maurice

@jaspermdegroot
Collaborator

Hi Anne and Maurice!

The issue with count bubble in a select button was already reported (#3979).

Jasper

@MauriceG

Hi Jasper !

And it seems, your awesome PR #4154 will hit this two!
I hope, it will be merged soon!

Maurice

@agcolom
Collaborator

Hi Jasper, Hi Maurice,

Well spotted ;-)
Thank you so much, and hope you have had a good weekend :-)

Anne

@jaspermdegroot
Collaborator

Closing as duplicate of #3979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.