Regression issue with multiple selects #4233

Closed
agcolom opened this Issue Apr 28, 2012 · 7 comments

Projects

None yet

3 participants

@agcolom
Member
agcolom commented Apr 28, 2012

Since 1.1.0, the text will go over the bubble on multiple selects:
http://jsfiddle.net/agcolom/4PX9x/18/show/ (latest)
http://jsfiddle.net/agcolom/4PX9x/19/show/ (1.1.0)

while it was cutting off nicely before:
http://jsfiddle.net/agcolom/4PX9x/20/show/ (1.0.1)

I think the padding right (here 45px) needs increasing since the bubble position has been modified.

@MauriceG MauriceG added a commit to MauriceG/jquery-mobile that referenced this issue Apr 28, 2012
@MauriceG MauriceG Fix for #4233 - Multiple selected values in multi select goes over bu…
…bble
73c458e
@MauriceG
Contributor

Hi Anne :-)
I've supplied PR #4235 for this issue.
Do you think 65px are enough?
May it looks a bit scarce?
Maurice

@agcolom
Member
agcolom commented Apr 28, 2012

Hi Maurice :-)

Yes, i did play around with values, and I think 65 is good. 60 was just a bit too small. I'm just unsure what else might get affected... We may to wait until Monday for this one... Hope you're having a good weekend :-)

Anne

On 28 Apr 2012, at 21:10, "Maurice Gottlieb" reply@reply.github.com wrote:

Hi Anne :-)
I've supplied PR #4235 for this issue.
Do you think 65px are enough?
May it looks a bit scarce?
Maurice


Reply to this email directly or view it on GitHub:
#4233 (comment)

The University of Westminster is a charity and a company limited by guarantee. Registration number: 977818 England. Registered Office: 309 Regent Street, London W1B 2UW.

@MauriceG
Contributor

yes, but in the unlikely case if more than 9 selected values,
the title again goes over the bubble.
Maurice

@jaspermdegroot
Member

Hi Anne and Maurice!

The issue with count bubble in a select button was already reported (#3979).

Jasper

@MauriceG
Contributor

Hi Jasper !

And it seems, your awesome PR #4154 will hit this two!
I hope, it will be merged soon!

Maurice

@agcolom
Member
agcolom commented Apr 29, 2012

Hi Jasper, Hi Maurice,

Well spotted ;-)
Thank you so much, and hope you have had a good weekend :-)

Anne

@jaspermdegroot
Member

Closing as duplicate of #3979

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment