New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selects + buttons inherit wrong font-size in list with form #4254

Closed
MauriceG opened this Issue May 1, 2012 · 6 comments

Comments

Projects
None yet
4 participants
@MauriceG
Contributor

MauriceG commented May 1, 2012

At http://jquerymobile.com/test/docs/lists/lists-forms.html the selectmenus and buttons at the end of the listview
look like mini but it seems they're just inherit the font-size of a list-divider (ui-li-divider).

@toddparker

This comment has been minimized.

Show comment
Hide comment
@toddparker

toddparker May 1, 2012

Contributor

Good catch. Fee free to do a pull if you can track this down.

Contributor

toddparker commented May 1, 2012

Good catch. Fee free to do a pull if you can track this down.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot May 7, 2012

Member

hi @ebaranov

Nice fix. I just wanted to suggest to put your rule in the listview.css file, not button.css, below the excisting rule for read-only/divider list items:

.ui-li-divider, .ui-li-static { padding: .5em 15px; font-size: 14px; font-weight: bold; }

Not that it won't work otherwise, but just to keep logical order.

Member

jaspermdegroot commented May 7, 2012

hi @ebaranov

Nice fix. I just wanted to suggest to put your rule in the listview.css file, not button.css, below the excisting rule for read-only/divider list items:

.ui-li-divider, .ui-li-static { padding: .5em 15px; font-size: 14px; font-weight: bold; }

Not that it won't work otherwise, but just to keep logical order.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot May 21, 2012

Member

This issue will solve itself when we make the changes to read-only lists including removal of the smaller font-size and padding for 1.2 (#4347). So we only need to cherry-pick the fix into the 1.1 stable branch and then remove again from master.

Member

jaspermdegroot commented May 21, 2012

This issue will solve itself when we make the changes to read-only lists including removal of the smaller font-size and padding for 1.2 (#4347). So we only need to cherry-pick the fix into the 1.1 stable branch and then remove again from master.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot May 25, 2012

Member

Closing as fixed.

Member

jaspermdegroot commented May 25, 2012

Closing as fixed.

@MauriceG

This comment has been minimized.

Show comment
Hide comment
@MauriceG

MauriceG May 25, 2012

Contributor

thanks @ebaranov!

Contributor

MauriceG commented May 25, 2012

thanks @ebaranov!

@ebaranov

This comment has been minimized.

Show comment
Hide comment
@ebaranov

ebaranov May 25, 2012

Contributor

You are welcome :)

Contributor

ebaranov commented May 25, 2012

You are welcome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment