This repository has been archived by the owner on Oct 8, 2021. It is now read-only.
Fixes: #1181 - navbar link stays active when using changePage() #4579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gePage() Clears the active button class on the pressed navbar button after a pagechange.
|
Actually this is not a specific navbar issue, but a general problem with the add/remove activeBtnClass functions (navigation.js). There are other cases where the active class is not removed while it should (for example #4611) and there are cases where buttons don't get the active class while this is desired (for example when the href contains only a hash). So I wanted to suggest to add a comment in the code after this PR is merged that it is a temporary fix that can be removed after we looked into the original cause. |
|
I am going to merge this PR to fix #1181 for now. When we do a refactor of the navbar widget for 1.4 we can look into why |
jaspermdegroot
added a commit
that referenced
this pull request
Feb 4, 2013
Fixes: #1181 - navbar link stays active when using changePage()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clears the active button class on the pressed navbar button after a
pagechange.