Slider Input Field uses ui-state-disabled instead of ui-disabled class #4637

Closed
patrick-wolf opened this Issue Jul 3, 2012 · 2 comments

Comments

Projects
None yet
2 participants
@patrick-wolf

For a disabled form element of type "Slider" the class ui-state-disabled is set for the input field, but it should actually be the class ui-disabled as it's for all other form widgets. ui-state-disabled isn't defined in the jQM css files that's why the slider input field appears enterable.

See http://jquerymobile.com/test/docs/forms/docs-forms.html (Disabling form elements)

Execute

$( "#slider" ).addClass( "ui-disabled" );

on that page to see the UI difference when setting the correct css class.

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Jul 3, 2012

Member

@patrickwolfat

The input field of the slider is enhanced by the textinput widget. The cause of the issue is the same as for #4637. The call to disable() is missing in the textinput widget. That function adds the "ui-disabled" class. The class "ui-state-disabled" is added by the jQuery UI widget factory that we use. So it's not just a typo that we need to fix.

Member

jaspermdegroot commented Jul 3, 2012

@patrickwolfat

The input field of the slider is enhanced by the textinput widget. The cause of the issue is the same as for #4637. The call to disable() is missing in the textinput widget. That function adds the "ui-disabled" class. The class "ui-state-disabled" is added by the jQuery UI widget factory that we use. So it's not just a typo that we need to fix.

jaspermdegroot added a commit that referenced this issue Jul 3, 2012

Merge pull request #4640 from uGoMobi/textinput
Fixes #4636 and #4637 - Class ui-disabled was not added during enhancement of disabled textinputs
@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Jul 3, 2012

Member

Closing as fixed.

Member

jaspermdegroot commented Jul 3, 2012

Closing as fixed.

jaspermdegroot added a commit that referenced this issue Jul 12, 2012

Textinput: added conditional call to disable() to the create function…
… to make sure disabled elements get class ui-disabled. Fixes #4636 and #4637 - Text Input doesn't use ui-disabled class if disabled attribute is set in markup. [1.1.2.]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment