New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using button tag in header will show title in new line and increase height of header toolbar #4638

Closed
patrick-wolf opened this Issue Jul 3, 2012 · 1 comment

Comments

Projects
None yet
2 participants
@patrick-wolf

If a button tag is used in the header toolbar then it will increase the height of the header toolbar because the title is displayed in a new line. Using anchors shows the expected behavior. According to http://jquerymobile.com/test/docs/toolbars/docs-headers.html any valid button markup should work. (-> "Each button is typically an anchor element, but any valid button markup will work." ).

The reason why I want to use the button tag is because it's semantically more correct than an anchor and it can easily be disabled/enabled.

Test case:

http://jsbin.com/awoluv/57

@ghost ghost assigned jaspermdegroot Jul 3, 2012

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Jul 3, 2012

Member

@patrickwolfat

Thanks for reporting the bug.

I will add "button" to the selector that now only contains the anchor element. Maybe the docs need to be adjusted a bit as well, because this functionality is not supposed to work for form buttons.

In the meantime you can fix it by adding class "ui-btn-left" to the button element in your markup.

Member

jaspermdegroot commented Jul 3, 2012

@patrickwolfat

Thanks for reporting the bug.

I will add "button" to the selector that now only contains the anchor element. Maybe the docs need to be adjusted a bit as well, because this functionality is not supposed to work for form buttons.

In the meantime you can fix it by adding class "ui-btn-left" to the button element in your markup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment