New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

submit button in header renders incorrectly #4642

Closed
jferguson opened this Issue Jul 4, 2012 · 4 comments

Comments

Projects
None yet
3 participants
@jferguson

jferguson commented Jul 4, 2012

classes ui-btn-right and ui-submit are added without space "ui-btn-rightui-submit" which causes the button to render 100% width and out of place. This code worked in 1.1.0:

    <div data-role="header" data-theme="d">
           <a data-icon="arrow-l" data-theme="d">Back</a>
           <h1 class="ui-title">Title</h1>
           <input type="submit" class="ui-btn-right" value="Save" />
    </div>
@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Jul 4, 2012

Member

@jferguson - Thanks for reporting the issue. Just fixed it.

Member

jaspermdegroot commented Jul 4, 2012

@jferguson - Thanks for reporting the issue. Just fixed it.

jaspermdegroot added a commit that referenced this issue Jul 10, 2012

Button widget: Rewrote code that adds class ui-submit. Fixes #4642 - …
…submit button in header renders incorrectly [1.1.2.]
@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jan 28, 2014

I still see this bug in 1.4.0. "button" and "input submit" are rendered incorrectly

ghost commented Jan 28, 2014

I still see this bug in 1.4.0. "button" and "input submit" are rendered incorrectly

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Jan 28, 2014

Member

@jitbit - Can you provide a simple test page? Thanks!

JS Bin template: http://jsbin.com/AKOmUxa/1/edit

Member

jaspermdegroot commented Jan 28, 2014

@jitbit - Can you provide a simple test page? Thanks!

JS Bin template: http://jsbin.com/AKOmUxa/1/edit

@ghost

This comment has been minimized.

Show comment
Hide comment
@ghost

ghost Jan 28, 2014

Sorry, my bad, forgot to add "ui-btn-right ui-btn ui-btn-inline" classes to my button... Sorry guys

ghost commented Jan 28, 2014

Sorry, my bad, forgot to add "ui-btn-right ui-btn ui-btn-inline" classes to my button... Sorry guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment