select menu data-placeholder not working with jQM 1.1.1 #4696

Closed
phillpafford opened this Issue Jul 13, 2012 · 8 comments

Comments

Projects
None yet
7 participants
@ErwanMAS

This comment has been minimized.

Show comment
Hide comment
@ErwanMAS

ErwanMAS Jul 13, 2012

Contributor

Regression is visible on the docs in the example 2 &3 from "Examples of various placeholder options" .

http://jquerymobile.com/demos/1.1.0/docs/forms/selects/custom.html
http://jquerymobile.com/demos/1.1.1/docs/forms/selects/custom.html

Contributor

ErwanMAS commented Jul 13, 2012

Regression is visible on the docs in the example 2 &3 from "Examples of various placeholder options" .

http://jquerymobile.com/demos/1.1.0/docs/forms/selects/custom.html
http://jquerymobile.com/demos/1.1.1/docs/forms/selects/custom.html

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Jul 14, 2012

Member

@phillpafford @ErwanMAS

This has been fixed on master (latest code). See http://jquerymobile.com/test/docs/forms/selects/custom.html
I will check how it is has been fixed, make sure the fix is in the 1.1.2. maintenance release, and see if I can provide you with a temporary workaround.

Member

jaspermdegroot commented Jul 14, 2012

@phillpafford @ErwanMAS

This has been fixed on master (latest code). See http://jquerymobile.com/test/docs/forms/selects/custom.html
I will check how it is has been fixed, make sure the fix is in the 1.1.2. maintenance release, and see if I can provide you with a temporary workaround.

@ghost ghost assigned jaspermdegroot Jul 14, 2012

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Jul 14, 2012

Member

@johnbender @gabrielschulhof

The issue first occured when Gabriel picked commit fd959b9 into 1.1-stable that changes select.custom.js
The problem doesn't seem to be the changes made by that commit, but more the fact that 3 other commits were not picked into 1.1-stable.
Those 3 commits regard changes in the setButtonText function in select.js
Commit ccd160d is a merge of a PR. Commits 0ad7c1e and c48768a are commits made by John.

Can you guys look into the best way to fix this for 1.1.2.?

Member

jaspermdegroot commented Jul 14, 2012

@johnbender @gabrielschulhof

The issue first occured when Gabriel picked commit fd959b9 into 1.1-stable that changes select.custom.js
The problem doesn't seem to be the changes made by that commit, but more the fact that 3 other commits were not picked into 1.1-stable.
Those 3 commits regard changes in the setButtonText function in select.js
Commit ccd160d is a merge of a PR. Commits 0ad7c1e and c48768a are commits made by John.

Can you guys look into the best way to fix this for 1.1.2.?

@MauriceG

This comment has been minimized.

Show comment
Hide comment
@MauriceG

MauriceG Sep 3, 2012

Contributor

@uGoMobi

This seems to be okay again with latest: http://jsfiddle.net/MauriceG/fMwQS/

@phillpafford Can you confirm that?

Maurice

Contributor

MauriceG commented Sep 3, 2012

@uGoMobi

This seems to be okay again with latest: http://jsfiddle.net/MauriceG/fMwQS/

@phillpafford Can you confirm that?

Maurice

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Sep 4, 2012

Member

@MauriceG

Yes it is ok on master / latest, but not on branch 1.1-stable. So if we do a 1.1.2. release this still won't work.

Member

jaspermdegroot commented Sep 4, 2012

@MauriceG

Yes it is ok on master / latest, but not on branch 1.1-stable. So if we do a 1.1.2. release this still won't work.

@Nemonocerater

This comment has been minimized.

Show comment
Hide comment
@Nemonocerater

Nemonocerater Sep 11, 2012

I was having the same problem and using the master / latest fixed the problem, but it made the select menu display constantly at the bottom of my page and then not center when I did select it. More details at my Stack Overflow question.

http://stackoverflow.com/questions/12376168/jquery-mobile-custom-select-menu-is-visible-when-unselected

I was having the same problem and using the master / latest fixed the problem, but it made the select menu display constantly at the bottom of my page and then not center when I did select it. More details at my Stack Overflow question.

http://stackoverflow.com/questions/12376168/jquery-mobile-custom-select-menu-is-visible-when-unselected

@ghost ghost assigned johnbender Sep 17, 2012

@JamesBrill

This comment has been minimized.

Show comment
Hide comment
@JamesBrill

JamesBrill Nov 10, 2012

Since 1.2.0, I've been having the same problem as Nemonocerater. Whenever the select menu is not dropped down, it is placed at the bottom of the page. Should a new issue thread be made about this?

Since 1.2.0, I've been having the same problem as Nemonocerater. Whenever the select menu is not dropped down, it is placed at the bottom of the page. Should a new issue thread be made about this?

@jaspermdegroot

This comment has been minimized.

Show comment
Hide comment
@jaspermdegroot

jaspermdegroot Nov 10, 2012

Member

@JamesBrill @Nemonocerater

Please open a new issue for the position problem if the problem still occurs when using latest code. See the contributing guidelines for our JS Bin and what information is required. Thanks!

Member

jaspermdegroot commented Nov 10, 2012

@JamesBrill @Nemonocerater

Please open a new issue for the position problem if the problem still occurs when using latest code. See the contributing guidelines for our JS Bin and what information is required. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment